Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing third party libraries #681

Closed
jeanlucf22 opened this issue Jan 26, 2023 · 10 comments
Closed

Testing third party libraries #681

jeanlucf22 opened this issue Jan 26, 2023 · 10 comments

Comments

@jeanlucf22
Copy link
Collaborator

We sometimes encounter failures due to problems in third-party libraries (not compiled properly, out of date,...). Tracking down these issues can take a lot of time.

To improve the situation, it would be nice to have some extras tests that test these third party libraries upfront and report issues right away, including performance issues.

@nicolasbock
Copy link
Collaborator

Let's start by compiling a list of those third-party libraries. That would make it easier to design and implement tests.

@jeanlucf22
Copy link
Collaborator Author

I would start with MAGMA, which has already caused us some trouble...

@nicolasbock
Copy link
Collaborator

Does the test pipeline you run via GitLab have access to GPUs? If it does then we could add tests that are run only there and not on GitHub.

@jeanlucf22
Copy link
Collaborator Author

Yes, it does run GPU.
BTW, we already have one test like that for OpenMP offload:

if(BML_OMP_OFFLOAD)

@nicolasbock
Copy link
Collaborator

Do you then basically just have to run a test in GitLab with OMP offload enabled?

@jeanlucf22
Copy link
Collaborator Author

All it does it run an extra test when BML_OMP_OFFLOAD=1 (on gitlab or not). This test is checking that compiler is actually offloading to GPU.
In the same way, we could have a test for MAGMA when MAGMA is ON.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Oct 27, 2023
@jeanlucf22
Copy link
Collaborator Author

PR #741 is the fist step with magma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants