Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: add hooks for JuMP extensions #101

Closed
wants to merge 1 commit into from
Closed

DNM: add hooks for JuMP extensions #101

wants to merge 1 commit into from

Conversation

odow
Copy link
Collaborator

@odow odow commented Sep 3, 2024

Closes #92

@pulsipher: what should we do about set_name, set_binary etc?

@odow
Copy link
Collaborator Author

odow commented Sep 3, 2024

This just feels wrong. It's an abstraction on top of JuMP to make two extensions work together. Can we not come up with a way where this just works normally?

@pulsipher
Copy link

what should we do about set_name, set_binary etc?

We could leave it as kwargs... or explicitly have them. I believe only set_name and set_binary are needed for MOAI.

This just feels wrong. It's an abstraction on top of JuMP to make two extensions work together. Can we not come up with a way where this just works normally?

I agree that it would be nice to more naturally have these extensions "just work" together. Here, I believe the core issue is that extensions at the JuMP level do not inherently compose all that well whereas MOI-level ones do.

With all that said, I still would very much like to avoid duplicating much of MOAI to work with InfiniteOpt. This PR may or may not be the right approach. I open to alternative strategies to facilitate the use of JuMP.AbstractVariables, including ones that might require changes to InfiniteOpt. There is no need to rush this.

@odow
Copy link
Collaborator Author

odow commented Sep 4, 2024

Here, I believe the core issue is that extensions at the JuMP level do not inherently compose

Yeah. I had mainly thought this applied to extensions that both created different AbstractVariableRef subtypes. It didn't occur to me that it would be a problem for basic @variable usage.

@odow odow changed the title WIP: add hooks for JuMP extensions DNM: add hooks for JuMP extensions Sep 4, 2024
@odow
Copy link
Collaborator Author

odow commented Oct 21, 2024

Closing because this is out-of-date, and I don't particularly like it. I'll leave the issue open and we can have another think.

@odow odow closed this Oct 21, 2024
@odow odow deleted the od/ext branch October 21, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extension point for AbstractModels with AbstractVariableRefs
2 participants