Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error/inconsistency in ManagedString MicroBit::getSerial() #17

Open
bsiever opened this issue May 8, 2020 · 0 comments
Open

Error/inconsistency in ManagedString MicroBit::getSerial() #17

bsiever opened this issue May 8, 2020 · 0 comments

Comments

@bsiever
Copy link

bsiever commented May 8, 2020

This may not be worth fixing at this point, but getSerial() breaks the serial number from microbit_serial_number() into two parts, the lower and then the upper. It returns a string that is the "lower + upper" rather than "upper + lower".

MakeCode will provide the serial number using the full int directly from microbit_serial_number(), so it shows the correct value from the NRF_FICR register.

The "reversed" value from getSerial() is used in the BLE Device Information Service and will be inconsistent with the serial number shown from MakeCode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant