From 62753623aaecd129d234efa7e9df0dde5a15decb Mon Sep 17 00:00:00 2001
From: Mike Ounsworth <mike.ounsworth@entrust.com>
Date: Sat, 30 Sep 2023 11:12:56 -0500
Subject: [PATCH 1/3] Fixed old ASN.1 in the body of the text

---
 draft-ietf-lamps-csr-attestation.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/draft-ietf-lamps-csr-attestation.md b/draft-ietf-lamps-csr-attestation.md
index 270d6bc..61142b7 100644
--- a/draft-ietf-lamps-csr-attestation.md
+++ b/draft-ietf-lamps-csr-attestation.md
@@ -236,7 +236,7 @@ id-aa-evidenceStatement OBJECT IDENTIFIER ::= { id-aa aa-evidenceStatement(TBDAA
 
 -- For PKCS#10
 attr-evidence ATTRIBUTE ::= {
-  TYPE EvidenceStatement
+  TYPE SEQUENCE OF EvidenceBundle
   IDENTIFIED BY id-aa-evidenceStatement
 }
 

From 882aa7ea05e84e3d6b087bd980c554412b7a81c0 Mon Sep 17 00:00:00 2001
From: Mike Ounsworth <mike.ounsworth@entrust.com>
Date: Mon, 2 Oct 2023 16:05:29 -0500
Subject: [PATCH 2/3] Added explanatory text to TCG DICE example. Closes #55.
 Closes #11

---
 draft-ietf-lamps-csr-attestation.md | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/draft-ietf-lamps-csr-attestation.md b/draft-ietf-lamps-csr-attestation.md
index 61142b7..5556521 100644
--- a/draft-ietf-lamps-csr-attestation.md
+++ b/draft-ietf-lamps-csr-attestation.md
@@ -52,9 +52,9 @@ author:
     country: Germany
 
 normative:
-    RFC9334:
-    RFC5912:
-    RFC4211:
+  RFC9334:
+  RFC5912:
+  RFC4211:
 
 informative:
   RFC2986:
@@ -72,6 +72,12 @@ informative:
     title: Baseline Requirements for Code-Signing Certificates, v.3.3
     date: June 2023
     target: https://cabforum.org/wp-content/uploads/Baseline-Requirements-for-the-Issuance-and-Management-of-Code-Signing.v3.3.pdf
+  TCGDICE1.1:
+    author:
+      org: Trusted Computing Group
+    title: DICE Attestation Architecture, v.1.1
+    date: May4, 2023
+    target: https://trustedcomputinggroup.org/wp-content/uploads/DICE-Attestation-Architecture-Version-1.1-Revision-17_1August2023.pdf
 
 --- abstract
 
@@ -669,6 +675,8 @@ information to an RA/CA:
 
 ## TCG DICE ConceptualMessageWrapper in CSR
 
+This section gives an example of extending the ASN.1 module above to carry an existing ASN.1-based evidence statement. The example used is the Trusted Computing Group DICE Attestation Conceptual Message Wrapper as defined in [TCGDICE1.1].
+
 ~~~
 {::include CSR-ATTESTATION-WITH-DICE-CMW.asn}
 ~~~

From 368a1ef0c173a451fb3a1e2909fc71094b2e60a4 Mon Sep 17 00:00:00 2001
From: Hannes Tschofenig <hannes.tschofenig@gmx.net>
Date: Tue, 3 Oct 2023 18:17:17 +0200
Subject: [PATCH 3/3] Adding RFC2986 back in

---
 draft-ietf-lamps-csr-attestation.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/draft-ietf-lamps-csr-attestation.md b/draft-ietf-lamps-csr-attestation.md
index 12c6f5c..c4b6298 100644
--- a/draft-ietf-lamps-csr-attestation.md
+++ b/draft-ietf-lamps-csr-attestation.md
@@ -55,6 +55,7 @@ normative:
   RFC9334:
   RFC5912:
   RFC4211:
+  RFC2986:
 
 informative:
   RFC7030: