Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stream wrapper functionality #28

Closed
weierophinney opened this issue Dec 31, 2019 · 5 comments · Fixed by #129
Closed

Remove stream wrapper functionality #28

weierophinney opened this issue Dec 31, 2019 · 5 comments · Fixed by #129
Assignees
@Ocramius
Labels
BC Break Duplicate This issue or pull request already exists
Milestone
3.0.0

Comments

@weierophinney
Copy link
Member

Fixes #23.

Originally posted by @mtymek at zendframework/zend-view#34
@weierophinney
Copy link
Member Author

Tests are failing, but it looks like compatibility issues with other ServiceManager v3.

Originally posted by @mtymek at zendframework/zend-view#34 (comment)

@weierophinney
Copy link
Member Author

As I said on #23,
Since PHP 5.4.0, <?= is always available.
Is this BC break ?
( situation when user uses extending \Zend\View\Stream ?)

Originally posted by @sasezaki at zendframework/zend-view#34 (comment)

@weierophinney
Copy link
Member Author

@sasezaki the reason this is labeled as BC break is removal of API (even if protected). The correct approach could be deprecation + removal of these method bodies, while the API survives till the next major release.

Originally posted by @Ocramius at zendframework/zend-view#34 (comment)

@weierophinney
Copy link
Member Author

@Ocramius thanks describe reason

Originally posted by @sasezaki at zendframework/zend-view#34 (comment)

@weierophinney
Copy link
Member Author

@sasezaki it's an API change, which means that any subclasses may be broken by the change (that's why we use private by default now)

Originally posted by @Ocramius at zendframework/zend-view#34 (comment)

@weierophinney weierophinney mentioned this issue Dec 31, 2019
Open
@gsteel gsteel mentioned this issue Jan 31, 2022
Merged
@Ocramius Ocramius added this to the 3.0.0 milestone Feb 1, 2022
@Ocramius Ocramius self-assigned this Feb 1, 2022
@Ocramius Ocramius added the Duplicate This issue or pull request already exists label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ocramius Ocramius

Labels
BC Break Duplicate This issue or pull request already exists
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Remove Stream Wrapper Functionality gsteel/laminas-view
2 participants
@weierophinney @Ocramius