Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 warnings #166

Closed
matbech opened this issue Jul 6, 2024 · 9 comments
Closed

PHP 8.4 warnings #166

matbech opened this issue Jul 6, 2024 · 9 comments
Assignees
Labels
Bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@matbech
Copy link
Contributor

matbech commented Jul 6, 2024

Please add support for PHP 8.4:

PHP Deprecated:  Laminas\Mvc\Application::__construct(): Implicitly marking parameter $events as nullable is deprecated, the explicit nullable type must be used instead in laminas-mvc\src\Application.php on line 95
PHP Deprecated:  Laminas\Mvc\Service\AbstractPluginManagerFactory::__invoke(): Implicitly marking parameter $options as nullable is deprecated, the explicit nullable type must be used instead in laminas-mvc\src\Service\AbstractPluginManagerFactory.php on line 24
@matbech matbech added the Bug Something isn't working label Jul 6, 2024
@Ocramius
Copy link
Member

Ocramius commented Jul 6, 2024

When 8.4 is added to CI

@HeenaBansal20
Copy link

When 8.4 support will be released ?

@Ocramius Ocramius added the dependencies Pull requests that update a dependency file label Nov 5, 2024
@froschdesign
Copy link
Member

@HeenaBansal20
Don't ask, help: #171 😃

@HeenaBansal20
Copy link

@froschdesign , composer install to 3.8.x-dev also throws error on PHP 8.4. my composer.josn is pretty generic

composer.json

{
    "require": {
        "laminas/laminas-mvc": "*",
        "laminas/laminas-i18n": "*"
    }
 }
>composer require  laminas/laminas-mvc 3.8.x-dev
Running composer update laminas/laminas-mvc
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - laminas/laminas-eventmanager 3.4.0 requires php ^7.3 || ~8.0.0 || ~8.1.0 -> your php version (8.4.0RC4) does not satisfy that requirement.
    - laminas/laminas-eventmanager 3.5.0 requires php ^7.4 || ~8.0.0 || ~8.1.0 -> your php version (8.4.0RC4) does not satisfy that requirement.
    - laminas/laminas-eventmanager[3.6.0, ..., 3.10.0] require php ~8.0.0 || ~8.1.0 || ~8.2.0 -> your php version (8.4.0RC4) does not satisfy that requirement.
    - laminas/laminas-eventmanager 3.11.0 requires php ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 -> your php version (8.4.0RC4) does not satisfy that requirement.
    - laminas/laminas-eventmanager[3.12.0, ..., 3.13.1] require php ~8.1.0 || ~8.2.0 || ~8.3.0 -> your php version (8.4.0RC4) does not satisfy that requirement.
    - laminas/laminas-mvc 3.8.x-dev requires laminas/laminas-eventmanager ^3.4 -> satisfiable by laminas/laminas-eventmanager[3.4.0, ..., 3.13.1].
    - Root composer.json requires laminas/laminas-mvc 3.8.x-dev -> satisfiable by laminas/laminas-mvc[3.8.x-dev].


Installation failed, reverting ./composer.json to its original content.

@gsteel
Copy link
Member

gsteel commented Nov 21, 2024

@HeenaBansal20
Event manager does not have a release that supports PHP 8.4 yet, which composer is accurately reporting to you.

PHP 8.4 support in MVC has already been released in 3.8.0

@gsteel gsteel closed this as completed Nov 21, 2024
@gsteel gsteel self-assigned this Nov 21, 2024
@gsteel
Copy link
Member

gsteel commented Nov 21, 2024

Correction: 3.8.0 has just been released

@froschdesign
Copy link
Member

@HeenaBansal20
You can view the progress here: https://github.com/orgs/laminas/projects/37

@HeenaBansal20
Copy link

@froschdesign Thank you. I see that support for event-manager PR didn't merge yet laminas/laminas-eventmanager#56

@HeenaBansal20
Copy link

@froschdesign , one more in line needs to be merged after CI check passes.
laminas/laminas-view#253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

5 participants