Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing return types for classes implementing core interfaces #311

Open
ovidiuenache opened this issue Aug 27, 2024 · 0 comments
Open

Comments

@ovidiuenache
Copy link

Feature Request

Q A
New Feature yes
RFC no
BC Break yes (for PHP < 7.4.0)

Summary

I noticed there are several classes that implement interfaces such as Iterator or Countable without adding the return types from the corresponding interfaces. Based on the existing #[\ReturnTypeWillChange] attribute I understand that the return type cannot be declared for an overriding method due to PHP cross-version compatibility concerns. But I don't understand why and for how long is the lack of return types still supported in the latest version of this package.

e.g. Laminas\Db\Sql\Join

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant