forked from matter-labs/zksync-era
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eigen-client-m0-implementation): optimize concurrent dispatcher #345
Merged
juan518munoz
merged 9 commits into
eigen-client-m0-grafana-metrics
from
eigen-client-optimize-concurrent-dispatcher
Nov 19, 2024
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
14d1d13
initial commit
juan518munoz 7951c3b
optimize dispatch_batches fn
juan518munoz 128f649
remove commented code
juan518munoz ae0b69f
remove needless variables
juan518munoz b11df04
optimize inclusion_poller fn
juan518munoz c5bae2d
break loop if dispatch fail
juan518munoz 8afd7d1
remove client_lock variable
juan518munoz 11b36b1
switch to retriable err
juan518munoz bb91fe4
replace arbitrary value with config
juan518munoz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not really nice, we could just do it all in a single line like we used to in our older implementation, and just call the disperse data before the disperse blob authenticated, since it doesnt depend on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of
drop
is widely used across the proyect's code (connection to the database for example).