feat(eigen-client-m0-implementation): optimize concurrent dispatcher #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -145,15 +154,14 @@ impl RawEigenClient { | |||
| .unwrap() | |||
| .payload | |||
| .ok_or_else(|| anyhow::anyhow!("No payload in response"))?; | |||
| drop(client_lock); | |||
There was a problem hiding this comment.
This is not really nice, we could just do it all in a single line like we used to in our older implementation, and just call the disperse data before the disperse blob authenticated, since it doesnt depend on it
There was a problem hiding this comment.
The use of drop is widely used across the proyect's code (connection to the database for example).
10 tasks
juanbono
approved these changes
Nov 19, 2024
juan518munoz
merged commit 54edd50
into
eigen-client-m0-grafana-metrics
12 of 24 checks passed
juan518munoz
added a commit
that referenced
this pull request
Nov 19, 2024
* initial commit * initial commit * fix ambiguous job name & add docker restart command * fix integration test command * update readme, remove fetching lambda repo * reorganize readme instructions * Fix concurrent dispatcher (#338) * Add shutdown to dispatch batches * Add JoinSet * Format code * Fix unbounded channel breaking authenticated dispersal * Fix pr comments * feat(eigen-client-m0-implementation): optimize concurrent dispatcher (#345) * initial commit * optimize dispatch_batches fn * remove commented code * remove needless variables * optimize inclusion_poller fn * break loop if dispatch fail * remove client_lock variable * switch to retriable err * replace arbitrary value with config --------- Co-authored-by: Gianbelinche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.