From f369ab9712d703199e47b05421ad6a3d048981fa Mon Sep 17 00:00:00 2001 From: Gianbelinche <39842759+gianbelinche@users.noreply.github.com> Date: Wed, 6 Nov 2024 16:42:43 -0300 Subject: [PATCH] Remove unused custom quorum numbers --- core/lib/config/src/configs/da_client/eigen.rs | 1 - core/lib/env_config/src/da_client.rs | 1 - core/lib/protobuf_config/src/da_client.rs | 5 ----- core/lib/protobuf_config/src/proto/config/da_client.proto | 1 - core/node/da_clients/src/eigen/client.rs | 3 --- 5 files changed, 11 deletions(-) diff --git a/core/lib/config/src/configs/da_client/eigen.rs b/core/lib/config/src/configs/da_client/eigen.rs index 4452e34e5f56..103845afa405 100644 --- a/core/lib/config/src/configs/da_client/eigen.rs +++ b/core/lib/config/src/configs/da_client/eigen.rs @@ -23,7 +23,6 @@ pub struct MemStoreConfig { #[derive(Clone, Debug, PartialEq, Deserialize, Default)] pub struct DisperserConfig { - pub custom_quorum_numbers: Option>, pub disperser_rpc: String, pub eth_confirmation_depth: i32, pub eigenda_eth_rpc: String, diff --git a/core/lib/env_config/src/da_client.rs b/core/lib/env_config/src/da_client.rs index f526e27e57a0..7dc5ece5db59 100644 --- a/core/lib/env_config/src/da_client.rs +++ b/core/lib/env_config/src/da_client.rs @@ -307,7 +307,6 @@ mod tests { assert_eq!( actual, DAClientConfig::Eigen(EigenConfig::Disperser(DisperserConfig { - custom_quorum_numbers: None, disperser_rpc: "http://localhost:8080".to_string(), eth_confirmation_depth: 0, eigenda_eth_rpc: "http://localhost:8545".to_string(), diff --git a/core/lib/protobuf_config/src/da_client.rs b/core/lib/protobuf_config/src/da_client.rs index d7395d7f22df..f1fbf26d89f0 100644 --- a/core/lib/protobuf_config/src/da_client.rs +++ b/core/lib/protobuf_config/src/da_client.rs @@ -73,7 +73,6 @@ impl ProtoRepr for proto::DataAvailabilityClient { } proto::eigen_config::Config::Disperser(conf) => { EigenConfig::Disperser(DisperserConfig { - custom_quorum_numbers: Some(conf.custom_quorum_numbers.clone()), disperser_rpc: required(&conf.disperser_rpc) .context("disperser_rpc")? .clone(), @@ -167,10 +166,6 @@ impl ProtoRepr for proto::DataAvailabilityClient { proto::data_availability_client::Config::Eigen(proto::EigenConfig { config: Some(proto::eigen_config::Config::Disperser( proto::DisperserConfig { - custom_quorum_numbers: config - .custom_quorum_numbers - .clone() - .unwrap_or_default(), disperser_rpc: Some(config.disperser_rpc.clone()), eth_confirmation_depth: Some(config.eth_confirmation_depth), eigenda_eth_rpc: Some(config.eigenda_eth_rpc.clone()), diff --git a/core/lib/protobuf_config/src/proto/config/da_client.proto b/core/lib/protobuf_config/src/proto/config/da_client.proto index 1875cd0ea194..a143d043ebe5 100644 --- a/core/lib/protobuf_config/src/proto/config/da_client.proto +++ b/core/lib/protobuf_config/src/proto/config/da_client.proto @@ -44,7 +44,6 @@ message MemStoreConfig { } message DisperserConfig { - repeated uint32 custom_quorum_numbers = 1; optional string disperser_rpc = 3; optional int32 eth_confirmation_depth = 4; optional string eigenda_eth_rpc = 5; diff --git a/core/node/da_clients/src/eigen/client.rs b/core/node/da_clients/src/eigen/client.rs index 8e62b9d63b0a..d6f4510ddd25 100644 --- a/core/node/da_clients/src/eigen/client.rs +++ b/core/node/da_clients/src/eigen/client.rs @@ -114,7 +114,6 @@ mod tests { #[tokio::test] async fn test_non_auth_dispersal() { let config = EigenConfig::Disperser(DisperserConfig { - custom_quorum_numbers: None, disperser_rpc: "https://disperser-holesky.eigenda.xyz:443".to_string(), eth_confirmation_depth: -1, eigenda_eth_rpc: "https://ethereum-holesky-rpc.publicnode.com".to_string(), @@ -153,7 +152,6 @@ mod tests { #[tokio::test] async fn test_auth_dispersal() { let config = EigenConfig::Disperser(DisperserConfig { - custom_quorum_numbers: None, disperser_rpc: "https://disperser-holesky.eigenda.xyz:443".to_string(), eth_confirmation_depth: -1, eigenda_eth_rpc: "https://ethereum-holesky-rpc.publicnode.com".to_string(), @@ -224,7 +222,6 @@ mod tests { #[tokio::test] async fn test_wait_for_finalization() { let config = EigenConfig::Disperser(DisperserConfig { - custom_quorum_numbers: None, disperser_rpc: "https://disperser-holesky.eigenda.xyz:443".to_string(), blob_size_limit: 2 * 1024 * 1024, // 2MB status_query_timeout: 1800000, // 30 minutes