Complete test suite of BuiltinRunner get_memory_segment_addresses
#1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono and
pefontana
as code owners
juanbono
approved these changes
Apr 5, 2024
Oppen
approved these changes
May 9, 2024
Oppen
added
tests
|
Flagged it |
fmoletta
removed
the
pipelines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete test suite of
BuiltinRunnerget_memory_segment_addressesDescription
A few test assertions are added to the test suite related to
get_memory_segment_addressesforBuiltinRunnerimplementation in order to complete the test coverage with all the implemented builtins.Checklist