Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homework Feedback - Node Week 5 #1

Open
jawkha opened this issue Oct 17, 2019 · 0 comments
Open

Homework Feedback - Node Week 5 #1

jawkha opened this issue Oct 17, 2019 · 0 comments

Comments

@jawkha
Copy link

jawkha commented Oct 17, 2019

Very impressive work. The website is very easy to navigate and very beautifully done. There are just a few minor things which I have listed below:

The site logo incorrectly refers to /home instead of / and therefore clicking it leads the user to a blank page.
https://github.com/Laila1222/meal-sharing/blob/16a514761bbdaa3876814618dce12b176cf17932/src/frontend/pages/home.js#L5

The link in the top navigation menu for Become a host makes a GET request to the endpoint /add-meal. However, this endpoint seems to be configured to handle only POST requests.
https://github.com/Laila1222/meal-sharing/blob/16a514761bbdaa3876814618dce12b176cf17932/src/backend/api/meals.js#L71

Due to a missing " here, the user is taken to an incorrect URL.
https://github.com/Laila1222/meal-sharing/blob/16a514761bbdaa3876814618dce12b176cf17932/src/frontend/pages/home.js#L45

You have commented here about this portion being still a work-in-process. Please let me know if you found this difficult to implement or could not make time for it.
https://github.com/Laila1222/meal-sharing/blob/a67220b1210eb31580d74ebb9fcd01bab0f1f958/src/frontend/pages/reviewsAndBook.js#L133

Overall, extremely impressive work. Keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant