Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing some mistakes #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Introducing some mistakes #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0aefc3
Introducing some mistakes.
Feb 2, 2020
dabdef9
One more mistake
Feb 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3020,6 +3020,7 @@ public void visitLambda(final JCLambda that) {
if (needsRecovery) {
attribTree(that, env, recoveryInfo);
}
return ; //wrong
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jackpot:
warning: The 'return' statement in the 'finally' block discards unhandled exceptions

}
}
//where
Expand Down
2 changes: 1 addition & 1 deletion test/langtools/tools/javac/patterns/BindingsExistTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* @test /nodynamiccopyright/
* @bug 8231827
* @summary Clashing bindings are reported correctly
* @compile/fail/ref=BindingsExistTest.out -XDrawDiagnostics --enable-preview -source ${jdk.version} BindingsExistTest.java
* @compile/fail/ref=BindingsExistTest.out -XDrawDiagnostics --enable-preview -source 15 BindingsExistTest.java
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jackpot:
warning: Hardcoded source version, should use ${jdk.version}

*/
public class BindingsExistTest {
public void t(Object o1, Object o2) {
Expand Down
2 changes: 1 addition & 1 deletion test/langtools/tools/javac/processing/TestMultipleErrors.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* @library /tools/javac/lib
* @modules jdk.compiler
* @build JavacTestingAbstractProcessor TestMultipleErrors
* @compile/fail/ref=TestMultipleErrors.out -XDrawDiagnostics -processor TestMultipleErrors TestMultipleErrors.java
* @compile/fail -XDrawDiagnostics -processor TestMultipleErrors TestMultipleErrors.java
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jackpot:
warning: Reference output missing

*/

import java.util.*;
Expand Down