Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some jobs are not done when too many sections are run async in the worker #4

Open
laggardkernel opened this issue Nov 25, 2020 · 1 comment

Comments

@laggardkernel
Copy link
Owner

Current behavior

When too many sections are enable with ::async, some of them failed to be rendered and placeholder is displayed. Seems some of the jobs are not done in the worker.

Need to dig it deeper when I have spare time.

Environment

Spaceship version: v4.5.0-8-g9ecf72b
Zsh version: zsh 5.8 (x86_64-apple-darwin18.7.0)
Zsh plugin manager: zinit
Terminal emulator: iTerm + tmux
Operating system: macOS 10.14.6

@laggardkernel
Copy link
Owner Author

laggardkernel commented Nov 25, 2020

Update 1: It turns out zpty -w $worker "$@"$'\0' failed after too many jobs have been sent, before zpty -r is called.


The unfinished jobs are passed into _async_send_job in zsh-async and added into worker by zpty -w $worker "$@"$'\0'. Besides, by searching async_stop_worker usage in this prompt, it's called only once in precmd hook, which is the expected behavior.

So, the bug is deemed a problem from zsh-async's implementation, but not my part, for the time being.

Ref: mafredri/zsh-async#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant