Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set minimum TF version for test workflows #69

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

tmac1973
Copy link
Contributor

Summary

This modules requires Terraform 1.4 and higher. Setting test workflow parameters to ensure that tests don't fail due to a lower version being tested.

Issue

https://lacework.atlassian.net/browse/GROW-2760

@badass-aoz
Copy link
Contributor

Looks good. Actually given we are here, can you just drop the 1.4 req and directly bump it to 1.5? It would help us add the run-time check block (https://developer.hashicorp.com/terraform/language/checks) that would help w/ UX.

@tmac1973
Copy link
Contributor Author

Bumping to 1.5 per @badass-aoz

@tmac1973 tmac1973 merged commit b7a38f8 into main Apr 11, 2024
9 checks passed
@tmac1973 tmac1973 deleted the tmacdonald/GROW-2760/codefresh-migration branch April 11, 2024 20:27
@lacework-releng lacework-releng mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants