bug: module.lacework_cfg_iam_role should pin a specific version

[jrobison-sb]

Describe the bug
This module consumes the lacework/iam-role/aws module, but doesn't pin a specific version of that module. This means that whenever the iam-role module ships a new version, users of the terraform-aws-config module will inherit that new version of iam-role without really knowing it.

Steps to reproduce

Take any terraform environment where you have used terraform-aws-config and you have already run terraform init before lacework/terraform-aws-iam-role#46 was merged, run terraform plan and see no diffs.

Then run rm -rf .terraform && terraform init && terraform plan which will pull in the new version of iam-role and you'll see diffs.

Expected behavior

You should never see diffs without explicitly bumping a version.

Screenshots
N/A

Please complete the following information):

• Terraform Version: v1.6.1
• Module Version: 0.13.0

[segfault79]

This has now also affected us after your release of 2.0. Any plans to pin the version?

[mgordziejewksi-clari]

Please fix it, it just broke my modules.

[PengyuanZhao]

@segfault79 @mgordziejewksi-clari we upgraded all modules to use lacework provider 2.0. Are you still running into any issues? Note that if you pin lacework/lacework to 1.0, please update it to 2.0.

[mgordziejewksi-clari]

One thing is upgrading the provider in one of the versions of your module, another is keeping the versions pinned in versions of your module. Right now, if you use old version of your module, it is entirely broken if you depend on 1.0 version in any place. I think it's just good practice that old versions of your module don't break out of sudden.

[PengyuanZhao]

@mgordziejewksi-clari Definitely. 1.0 stopped working due to a breaking change in one of its dependencies. We had to force all customers to use 2.0 Sorry for the trouble. Here is a related thread lacework/terraform-aws-iam-role#60