Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of account list #1

Open
lacedaemon98 opened this issue Apr 17, 2020 · 1 comment
Open

Order of account list #1

lacedaemon98 opened this issue Apr 17, 2020 · 1 comment

Comments

@lacedaemon98
Copy link
Owner

Order of account list always get changed randomly when I add new account or rename an account. For example, when I added 3 accounts test, test1 and test3 consecutively, the list show this

image.png

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 21, 2020

Team's Response

Thank you for this question, my team has considered about this when we developed the application. We make use of the hashmap instead of list to store all the accounts, this decision helps to add other account operations.
So to us, this is not a flaw, it is something we trade for time complexity.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: After renaming something (e.g account number 3) to something else, the user would likely want to list all the accounts again to check if the renaming was done properly. In this case, wouldn't it be very confusing for the user to find that the whole list of account jumble up?

I think that this behaviour should be documented (especially in the DG) if you want to trade for time complexity to let the user understand better.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants