Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent reload on transaction change #99

Open
sohrab- opened this issue Dec 28, 2022 · 2 comments
Open

Prevent reload on transaction change #99

sohrab- opened this issue Dec 28, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@sohrab-
Copy link
Member

sohrab- commented Dec 28, 2022

What happened?

Some components, e.g. export modal or send/simulate button, need the whole transaction so they are reloaded every time any part of the transaction changes. In reality, these components only need the entire transaction as a callback, e.g. when the export modal is opened or when send/simulate button is pressed.

Is there a way to lazily load the transaction from the state store only on those callbacks?

Errors & Logs

No response

App Version

v1.0.0-alpha.57 (101-1)

Web Browser

Brave v1.46.144 (Dec 14, 2022)

@sohrab- sohrab- added the bug Something isn't working label Dec 28, 2022
@sohrab-
Copy link
Member Author

sohrab- commented Jan 7, 2023

Made some refactoring to avoid some re-renders:

There is definitely more work to be done here. We need to investigate the re-renders using react devtools profiler.

@sohrab-
Copy link
Member Author

sohrab- commented Jan 25, 2023

Fixed an issue with Solana's Connection class causing re-renders: 639d6f0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant