New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling > SSE 2 support for default python installation while keeping compatibility with M1 #404

Open

agoscinski opened this issue Apr 6, 2022 · 0 comments

Labels

Contributor

agoscinski commented Apr 6, 2022

From the conversation in PR #403

Should we add march at least to the default pip installation?

librascal/setup.py

Line 31 in 9a9fbdc

cmake_args=[

Since march seems to potentially give speed ups for numerical code by enabling SSE 2 > instructions.
https://stackoverflow.com/a/52660117

Originally posted by @agoscinski in #403 (comment)

No, because this would also fail when compiling the python binding on M1 CPU.
If someone wants to put in the time to figure out a robust way to add back -march=native without breaking some platforms, we can do it later, but I would rather have something which works for now.

Originally posted by @Luthaf in #403 (comment)

The text was updated successfully, but these errors were encountered:

agoscinski added the optimization label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment