Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

any support for .net core #20

Open
pinopino opened this issue Jul 18, 2019 · 4 comments
Open

any support for .net core #20

pinopino opened this issue Jul 18, 2019 · 4 comments

Comments

@pinopino
Copy link

when i use this for a .net core dll(.net core 2.1), it stop works and just output these lines:

Failed to resolve assembly: 'System.Runtime, Version=4.2.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
@mvw684
Copy link

mvw684 commented Feb 17, 2020

I have a similar issue, I have an assembly which defines some attribute and an enum as constructor argument (both in assembly 'a').
Then in assembly 'b' I have this attribute as an assembly attribute.

Now the injection fails also with an assembly not found message (same as with .NET Core/.NET Standard, we experienced that issue as well)

I have locally patched the code to accept additional assembly resolve folders.
Then adding the folder of assembly 'a' to the arguments solves the issue for us.

Program.cs
Injector.cs

I'll look into the contributing sections to see what would be the best way to contribute these changes.

Regards,
Mark

@mvw684
Copy link

mvw684 commented Jun 22, 2021

Hi,

I have forked the InjectModuleInitializer and added support for adding assembly search paths on the commandline.
See https://github.com/mvw684/InjectModuleInitializer/ should I submit a pull request for that change? Not sure what is required in form of additional tests/documentation.

@einaregilsson
Copy link
Contributor

I'm not the maintainer for this anymore, so I can't answer whether you should make a pull request, but I did notice that you have a typo in the regex on line 60 in program.cs: mvw684@d6d27c3#diff-0b69b473fe937040615d69f606751f61ddbc2e3a1849360ff2456c22afe88c0bR60

It says 'assemnby' instead of 'assembly'.

@mvw684
Copy link

mvw684 commented Jul 20, 2021

Typo is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants