This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Aggregate and display failures at the bottom of output with minor code refactoring. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdiAkhileshSingh15
requested review from
eddycharly and
chipzoller
as code owners
AdiAkhileshSingh15
changed the title
Signed-off-by: AdiAkhileshSingh15 <[email protected]>
Signed-off-by: AdiAkhileshSingh15 <[email protected]>
AdiAkhileshSingh15
force-pushed
the
main
branch
from
3bcdd38
to
5b9a58a
Compare
Signed-off-by: AdiAkhileshSingh15 <[email protected]>
This reverts commit 1496216. This commit was supposed to be done in a different pr. Signed-off-by: AdiAkhileshSingh15 <[email protected]>
AdiAkhileshSingh15
force-pushed
the
main
branch
from
4e8f4e3
to
d82aa52
Compare
|
Closing, done in #30 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #25, while also incorporating code refactoring to enhance error messages and code-reusability. Please provide feedback if the current approach of logging errors is not aligned with the intended behavior or if there are any suggestions for further improvements.