Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Directory.Build.targets parsing and getting Target nodes #35

Merged
merged 3 commits into from
May 3, 2024

Conversation

FrediKats
Copy link
Member

Close #33

Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 93.27%. Comparing base (0c37c7d) to head (a8705ca).

❗ Current head a8705ca differs from pull request most recent head 08e59cc. Consider uploading reports for the commit 08e59cc to get more accurate results

Files Patch % Lines
...ProjectSystem/Projects/DirectoryBuildTargetFile.cs 45.00% 10 Missing and 1 partial ⚠️
...tem/SolutionModification/DotnetSolutionModifier.cs 42.85% 2 Missing and 2 partials ⚠️
...utionModification/DotnetSolutionModifierFactory.cs 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   95.14%   93.27%   -1.88%     
==========================================
  Files          28       29       +1     
  Lines         700      743      +43     
  Branches       80       85       +5     
==========================================
+ Hits          666      693      +27     
- Misses         20       32      +12     
- Partials       14       18       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrediKats FrediKats merged commit feac143 into master May 3, 2024
1 check passed
@FrediKats FrediKats deleted the feat/directory-build-targets branch May 3, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Directory.Build.targets parsing and getting Target nodes
1 participant