Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clonescan: warning on install and breaks itself and kvirc. #11

Open
un1versal opened this issue Jan 7, 2016 · 3 comments
Open

clonescan: warning on install and breaks itself and kvirc. #11

un1versal opened this issue Jan 7, 2016 · 3 comments

Comments

@un1versal
Copy link
Contributor

Reported by sdd via IRC on 6th Jan 2016
Also message reads:


And The script keeps running endlessly long after all clones are identified, this is a big nono.

When you first run, it hangs the whole KVIrc while its doing initial something, you cant do anything, cant change windows, channels, type, --anything is like frozen, then once its finished KVIrc is once again usable.

You run it in one network in one channel it transverses multiple networks and prints in console multiple entries that read:

[07:44:25] hell_clonescan is an unknown server command
[07:45:01] hell_clonescan is an unknown server command
[07:45:20] hell_clonescan is an unknown server command
[07:45:21] hell_clonescan is an unknown server command
[07:48:14] hell_clonescan is an unknown server command
[07:48:15] hell_clonescan is an unknown server command
[07:48:43] hell_clonescan is an unknown server command

Console output on install

[07:21:26] Attempting to register addon "HellClonescan" with version 1.0
[07:21:26] Addon successfully registered
[07:21:26] [KVS] Warning: The alias 'hell_clonescan_remove' does not exist
[07:21:26] [KVS]   In script context "installer::generateUninstallAlias", line 11, near character 8

Debug output on install

[07:21:26] [KVS] Warning: The alias 'hell_clonescan_remove' does not exist
[07:21:26] [KVS]   In script context "installer::generateUninstallAlias", line 11, near character 8
[07:21:26] [KVS] Code listing:
[07:21:26] [KVS]   9 ...
[07:21:26] [KVS]   10 %c .= "}"
[07:21:26] [KVS]   11 eval %c
[07:21:26] [KVS] Window:
[07:21:26] [KVS]   #KVIrc [id: 5]
[07:21:26] [KVS] Call stack:
[07:21:26] [KVS]   #0 Core Callback Command "alias" [line 11, near character 8]
[07:21:26] [KVS]
KVIrc 4.9.1 'Aria'

Runtime Info:
System name: Linux 3.13.0-71-generic
System version: #114-Ubuntu SMP Tue Dec 1 02:34:22 UTC 2015
Architecture: x86_64
Qt version: 5.2.1
Qt theme: fusion

Build Info:
Build date: 2016-01-06 18:10:45 UTC
Sources date: 20160102
Revision number: git-6054-gf20c74a
System name: Linux-3.13.0-71-generic
CPU name: x86_64
Build command: /usr/bin/cmake
Build flags: 
   MANDIR=man
   CMAKE_INSTALL_PREFIX=/usr
   LIB_SUFFIX=/x86_64-linux-gnu
   Threads=POSIX
Compiler name: /usr/bin/c++
Compiler flags: N/A
Qt version: 5.2.1

@HelLViS69

@un1versal un1versal changed the title clonescan: warning on install clonescan: warning on install and breaks itself and kvirc. Jan 7, 2016
@un1versal
Copy link
Contributor Author

I can confirm this script keeps running after its been stopped and uninstalled / removed manually...

It keeps running even after kvirc has been stopped/restarted without it being called or activated or even existing in classes/aliases

The script is at best broken and should be marked broken by placing a file inside that reads broken do not use.

@wodim
Copy link
Member

wodim commented Jan 7, 2016

Or you could fix it.

@un1versal
Copy link
Contributor Author

Well if I knew how to fix everything it would all be done...

Have no doubt about that statement, scripts and kvirc bugs alike and everything else in between.

minduser00 added a commit to minduser00/kvirc-scripts that referenced this issue Jul 16, 2017
Fix for the error that occurs if the createUninstallAlias ​​function is called, when the variable %iNumFiles = 0, this generates an alias(aliasName){}  so an empty alias is not created, but an attempt is made to delete one that Does not exist yet.
Issue kvirc#11 opened on Jan 7, 2016 by un1versal
The rest of the addon is still broken
minduser00 added a commit to minduser00/kvirc-scripts that referenced this issue Aug 25, 2017
Fix for the clonescan.
Issue kvirc#11 opened on Jan 7, 2016 by un1versal
In this state does not seem to have any type of malfunction.
minduser00 added a commit to minduser00/kvirc-scripts that referenced this issue Sep 4, 2017
* Update installer.kvs

Small typo.

* Update installer.kvs

Fix for the error that occurs if the createUninstallAlias ​​function is called, when the variable %iNumFiles = 0, this generates an alias(aliasName){}  so an empty alias is not created, but an attempt is made to delete one that Does not exist yet.
Issue kvirc#11 opened on Jan 7, 2016 by un1versal
The rest of the addon is still broken

* Update install.kvs

This in not now playing addon

* Update install.kvs

Moved class(helltrixclone,object) out of the alias hell_clonescan

* Update install.kvs

# Patch 
The menu persisted after the uninstall

* Update install.kvs

more simple

* Update install.kvs

Uninstallation complete now

* Update install.kvs

simplified

* Update install.kvs

Bug in uninstall callback

* Update install.kvs

Fix global clon scan

* Update install.kvs

When a user who shares several channels with our KVIrc, enters the channels and is a clone, our current window is filled with the warnings of the clone detector.
And if a user who is a clone enters when we have a window open that is not a channel or console, the information is lost.
Each clone entry should appear on the channels it entered.
This patch solves it

* Update install.kvs

Error in help message

* Update install.kvs

Closing instances of clonescan object

* Update install.kvs

Patch for a bug which closes the current window if the clonescan not create any window

* Update install.kvs

Changed global variables by variable fields.
At this point, the script works without errors, but with a problem, every time a global scan is done, a new window is created, even for the same channel, it is not reused. If the user does not close them, when uninstalling the script, they remain open

* Fix clonescan

Now the script only opens one window per context, and remembers the windows it has opened, to close them if you uninstall the script

* big bug, mea culpa

if a  /hell_clonescan NickNotInChannel   is done a list of all of users of the channel is printed in the channel, because $mask.host("") returns *

* Warning patch

Patch to avoid a warning message, if the clonescan is called from a window that is not a channel

* Update install.kvs

#Fix for the clonescan.

In this state does not seem to have any type of malfunction.

* Update install.kvs

two messages fix

* Create po dir

* Added laguaje files

Added helltrix.pot and helltrix_es.po

* Create locale dir

* Added helltrix_es.mo

Added spanish translation

* add icon

Adding an icon and unloading translation file

* pics dir

* Add files via upload

Added image hell_clonescan.png

* not more installer

now the clonescan not more uses de installer helper class

* updated po{t}

* helltrix_es.mo update

* Delete installer.kvs

It is no longer necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants