-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clonescan: warning on install and breaks itself and kvirc. #11
Comments
I can confirm this script keeps running after its been stopped and uninstalled / removed manually... It keeps running even after kvirc has been stopped/restarted without it being called or activated or even existing in classes/aliases The script is at best broken and should be marked broken by placing a file inside that reads |
Or you could fix it. |
Well if I knew how to fix everything it would all be done... Have no doubt about that statement, scripts and kvirc bugs alike and everything else in between. |
Fix for the error that occurs if the createUninstallAlias function is called, when the variable %iNumFiles = 0, this generates an alias(aliasName){} so an empty alias is not created, but an attempt is made to delete one that Does not exist yet. Issue kvirc#11 opened on Jan 7, 2016 by un1versal The rest of the addon is still broken
Fix for the clonescan. Issue kvirc#11 opened on Jan 7, 2016 by un1versal In this state does not seem to have any type of malfunction.
* Update installer.kvs Small typo. * Update installer.kvs Fix for the error that occurs if the createUninstallAlias function is called, when the variable %iNumFiles = 0, this generates an alias(aliasName){} so an empty alias is not created, but an attempt is made to delete one that Does not exist yet. Issue kvirc#11 opened on Jan 7, 2016 by un1versal The rest of the addon is still broken * Update install.kvs This in not now playing addon * Update install.kvs Moved class(helltrixclone,object) out of the alias hell_clonescan * Update install.kvs # Patch The menu persisted after the uninstall * Update install.kvs more simple * Update install.kvs Uninstallation complete now * Update install.kvs simplified * Update install.kvs Bug in uninstall callback * Update install.kvs Fix global clon scan * Update install.kvs When a user who shares several channels with our KVIrc, enters the channels and is a clone, our current window is filled with the warnings of the clone detector. And if a user who is a clone enters when we have a window open that is not a channel or console, the information is lost. Each clone entry should appear on the channels it entered. This patch solves it * Update install.kvs Error in help message * Update install.kvs Closing instances of clonescan object * Update install.kvs Patch for a bug which closes the current window if the clonescan not create any window * Update install.kvs Changed global variables by variable fields. At this point, the script works without errors, but with a problem, every time a global scan is done, a new window is created, even for the same channel, it is not reused. If the user does not close them, when uninstalling the script, they remain open * Fix clonescan Now the script only opens one window per context, and remembers the windows it has opened, to close them if you uninstall the script * big bug, mea culpa if a /hell_clonescan NickNotInChannel is done a list of all of users of the channel is printed in the channel, because $mask.host("") returns * * Warning patch Patch to avoid a warning message, if the clonescan is called from a window that is not a channel * Update install.kvs #Fix for the clonescan. In this state does not seem to have any type of malfunction. * Update install.kvs two messages fix * Create po dir * Added laguaje files Added helltrix.pot and helltrix_es.po * Create locale dir * Added helltrix_es.mo Added spanish translation * add icon Adding an icon and unloading translation file * pics dir * Add files via upload Added image hell_clonescan.png * not more installer now the clonescan not more uses de installer helper class * updated po{t} * helltrix_es.mo update * Delete installer.kvs It is no longer necessary
Reported by sdd via IRC on 6th Jan 2016
Also message reads:
And The script keeps running endlessly long after all clones are identified, this is a big nono.
When you first run, it hangs the whole KVIrc while its doing initial something, you cant do anything, cant change windows, channels, type, --anything is like frozen, then once its finished KVIrc is once again usable.
You run it in one network in one channel it transverses multiple networks and prints in console multiple entries that read:
Console output on install
Debug output on install
@HelLViS69
The text was updated successfully, but these errors were encountered: