Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options for sending logging when reaching capacity or timeout #20

Open
XinleiYang7 opened this issue Jul 2, 2019 · 1 comment
Open

Comments

@XinleiYang7
Copy link

sending the errors message to server when the errors reach maximum length capacity instead of dropping the oldest within the interval.

@kutuluk
Copy link
Owner

kutuluk commented Jul 3, 2019

If the queue limit is reached, then the server is most likely disconnected or it does not have time to process incoming logs and an error message to send to it meaningless. Messages in any case need to be deleted, because it is impossible to make a queue of infinite, otherwise there is a chance to spend all the RAM. In addition, the server does not need to know whether the queue is full on the client or not, because it still will not be able to somehow influence this situation. In addition, sending a message of overcrowding is also added to the queue, which further aggravates the situation. In the aggregate, I think that the current implementation is the most correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants