implement custom machine controller #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preliminary-kurator canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hzxuzhonghu
force-pushed
the
custom-machine
branch
from
582b865
to
9730099
Compare
zirain
reviewed
Nov 29, 2022
|
|
||
| "github.com/pkg/errors" |
zirain
reviewed
Nov 29, 2022
| if err := r.externalTracker.Watch(log, obj, &handler.EnqueueRequestForOwner{OwnerType: &clusterv1alpha1.CustomMachine{}}); err != nil { | ||
| return ctrl.Result{}, err | ||
| } | ||
| // TODO: Set customMachine.status.ready=true |
zirain
reviewed
Nov 29, 2022
| @@ -50,6 +50,8 @@ type CustomMachineSpec struct { | |||
| // CustomMachineStatus represents the current status of the machine. | |||
| type CustomMachineStatus struct { | |||
| // TODO add state. | |||
| // Indicate whether the machines are ready. | |||
| Ready *bool `json:"ready,omitempty"` | |||
There was a problem hiding this comment.
add a TODO for display this in kubectl get custommachine
Signed-off-by: Zhonghu Xu <[email protected]>
hzxuzhonghu
force-pushed
the
custom-machine
branch
from
9730099
to
cd577de
Compare
Signed-off-by: Zhonghu Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custom machine controller is very simple now:
it does two kinds of work: