Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number Guessing Game is added #4789

Merged
merged 5 commits into from
Jul 27, 2024
Merged

Conversation

Ishitamukherjee2004
Copy link
Contributor

@Ishitamukherjee2004 Ishitamukherjee2004 commented Jul 9, 2024

PR Description 📜

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #4788


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Number.Guess.-.Made.with.Clipchamp.mp4


Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jul 9, 2024

Thank you @Ishitamukherjee2004 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@Ishitamukherjee2004
Copy link
Contributor Author

/assign

@Ishitamukherjee2004
Copy link
Contributor Author

@kunjgit @ishita-43
please review the pr and merge it.

@Ishitamukherjee2004
Copy link
Contributor Author

Ishitamukherjee2004 commented Jul 25, 2024

@kunjgit @ishita-43 Please review the pr and reply.

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late review
You need to make these changes in your PR
Add your game entry into readme. Md file of the gamezone repo
Add your game image in the assets folder of the repo follow naming convention for image

@Ishitamukherjee2004
Copy link
Contributor Author

@ishita-43 I have updated it please check

@ishita-43
Copy link
Collaborator

@ishita-43 I have updated it please check

Also add your game name in main readme.md file of the gamezone follow other entries for the format you will find this in same hierarchy as the assets folder there you need to update that file with your entry of game

@Ishitamukherjee2004
Copy link
Contributor Author

@ishita-43 File is updated pls check

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@ishita-43 ishita-43 added level2 Enhancement in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jul 27, 2024
@kunjgit kunjgit merged commit 9d45fe6 into kunjgit:main Jul 27, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jul 27, 2024

Thank you @Ishitamukherjee2004 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level2 Enhancement in gssoc Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Number Guessing Game
3 participants