Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Pattern Creation Game #4695

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Added Pattern Creation Game #4695

merged 5 commits into from
Jul 8, 2024

Conversation

ananyag309
Copy link
Contributor

Issue #4694
Added Pattern Creation Game
@ishita-43 please have a look, i have followed all the contributing rules. Have a check and add gssoc and level label.
thank you

WhatsApp.Video.2024-06-24.at.19.12.19_a8f4bf12.mp4

@kunjgit
Copy link
Owner

kunjgit commented Jun 24, 2024

Thank you @ananyag309 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@ananyag309
Copy link
Contributor Author

/assign

ishita-43
ishita-43 requested changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add you game image in asset folder of the gamezone repo.

@ananyag309
Copy link
Contributor Author

@ishita-43 ma'am please check I have made necessary changes.

@ananyag309
Copy link
Contributor Author

@ishita-43 @kunjgit sorry for disturbing again. it's been a week. please have a check & please letme know if any further changes need to be made.

ishita-43
ishita-43 requested changes Jul 7, 2024
View reviewed changes
README.md Outdated
@@ -825,7 +825,7 @@ This repository also provides one such platforms where contributers come over an
|[Wheel_of_Fortunes](https://github.com/Saipradyumnagoud/GameZone/tree/main/Games/Wheel_of_Fortunes)|
|[Tic-tac-toe](https://github.com/Saipradyumnagoud/GameZone/tree/main/Games/Tic-tac-toe)|
|[Quest_For_Riches](https://github.com/kunjgit/GameZone/tree/main/Games/Quest_For_Riches)|

|[Pattern Creation Game](https://github.com/ananyag309/GameZone_ggsoc/tree/main/Games/Pattern_Creation_Game)|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change your name with the repository name as other did eg kunjgit/GameZone

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label labels Jul 7, 2024
ishita-43
ishita-43 approved these changes Jul 7, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go!!

@kunjgit kunjgit merged commit f178fb3 into kunjgit:main Jul 8, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jul 8, 2024

Thank you @ananyag309 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

This was referenced Jul 12, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees

@ananyag309 ananyag309

Labels
gssoc GSSoC24 program label level3 Adding new features Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ananyag309 @kunjgit @ishita-43