Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Makeover Game #4615

Merged
merged 9 commits into from
Jul 8, 2024
Merged

added Makeover Game #4615

merged 9 commits into from
Jul 8, 2024

Conversation

abckhush
Copy link
Contributor

@abckhush abckhush commented Jun 18, 2024

PR Description 📜

added Makeover_Game
Fixes #4603


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Makeover_Game



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 18, 2024

Thank you @abckhush ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@abckhush
Copy link
Contributor Author

Hi @ishita-43. Kindly review this PR.

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please addd your game image in asset folder of the gamezone and follow naming convention while naming that image

@abckhush
Copy link
Contributor Author

abckhush commented Jul 1, 2024

Hi @ishita-43 I have added, kindly check.

@abckhush abckhush changed the title adde Makeover Game added Makeover Game Jul 1, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the image same as your game folder name follow contribution guidelines for naming convention

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry for the overlook, can you check now?

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!!

@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label labels Jul 7, 2024
@kunjgit kunjgit merged commit 23648b0 into kunjgit:main Jul 8, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jul 8, 2024

Thank you @abckhush , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level3 Adding new features Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Makeover Game
3 participants