Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tic-Tac-Toe Game Added #3881

Merged
merged 5 commits into from
Jun 2, 2024
Merged

Tic-Tac-Toe Game Added #3881

merged 5 commits into from
Jun 2, 2024

Conversation

jency1
Copy link
Contributor

@jency1 jency1 commented May 29, 2024

PR Description 📜

Fixes #3873

Tic-Tac-Toe Game Added

Features

  • Interactive Game Board: Play on a 3x3 grid.
  • Two-Player Mode: Play with a friend.
  • Reset Game: Easily reset to a new game.
  • New Game: Easily start a new game.

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Tic-Tac-Toe Game

@kunjgit
Copy link
Owner

kunjgit commented May 29, 2024

Thank you @jency1 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jency1,
You need to make the following changes:

  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

@jency1 jency1 requested a review from kunjgit May 29, 2024 20:18
@kunjgit
Copy link
Owner

kunjgit commented May 30, 2024

@jency1 resolve merge conflicts !

@jency1
Copy link
Contributor Author

jency1 commented May 30, 2024

@jency1 resolve merge conflicts !

@kunjgit Please review and merge this PR.

I have resolved the merge conflict issue.

@jency1
Copy link
Contributor Author

jency1 commented May 31, 2024

@kunjgit Please review and merge this PR.

I have resolved the merge conflict issue.

1 similar comment
@jency1
Copy link
Contributor Author

jency1 commented Jun 1, 2024

@kunjgit Please review and merge this PR.

I have resolved the merge conflict issue.

@jency1
Copy link
Contributor Author

jency1 commented Jun 2, 2024

@kunjgit Please review and merge this PR.

I have resolved the merge conflict issues.

@jency1
Copy link
Contributor Author

jency1 commented Jun 2, 2024

@kunjgit Please review and merge this PR.

I have resolved the merge conflict issues.

@kunjgit kunjgit merged commit 349bf75 into kunjgit:main Jun 2, 2024
1 check passed
@kunjgit
Copy link
Owner

kunjgit commented Jun 2, 2024

Thank you @jency1 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@kunjgit kunjgit added level3 Adding new features gssoc GSSoC24 program label and removed Pending ⏱️ Changes Requested ⚒️ Changes have to be done labels Jun 2, 2024
@jency1
Copy link
Contributor Author

jency1 commented Jun 2, 2024

@kunjgit Thanks for merging the PR.

Please assign this PR and issue to me, as this PR won't be counted if it is not assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level3 Adding new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Tic-Tac-Toe
2 participants