Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Flames Game #3855

Closed
wants to merge 11 commits into from
Closed

Added Flames Game #3855

wants to merge 11 commits into from

Conversation

Saipradyumnagoud
Copy link
Contributor

@Saipradyumnagoud Saipradyumnagoud commented May 28, 2024 •
edited
Loading

PR Description 📜

Added Flames game where user can give there name and crush name to find the relation

Fixes #3822

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented May 28, 2024

Thank you @Saipradyumnagoud ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

kunjgit
kunjgit requested changes May 28, 2024
View reviewed changes
Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Saipradyumnagoud,
You need to make the following changes:

  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

kunjgit
kunjgit requested changes May 28, 2024
View reviewed changes
Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Saipradyumnagoud,
You need to make the following changes:

  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

kunjgit
kunjgit requested changes May 28, 2024
View reviewed changes
Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Saipradyumnagoud,
You need to make the following changes:

  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

kunjgit
kunjgit requested changes May 28, 2024
View reviewed changes
Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Saipradyumnagoud,
You need to make the following changes:

  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

kunjgit
kunjgit requested changes May 28, 2024
View reviewed changes
Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Saipradyumnagoud,
You need to make the following changes:

  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

@Saipradyumnagoud
Copy link
Contributor Author

What should i modify in readme

@Saipradyumnagoud
Copy link
Contributor Author

I have added assets/images directory
I have added Readme.md file also
could you please tell me what else should I do

kunjgit
kunjgit requested changes May 29, 2024
View reviewed changes
Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Saipradyumnagoud,
You need to make the following changes:

  • Please modify the main README.md file.

Hoping that you will make those changes soon 🚀

Saipradyumnagoud
Saipradyumnagoud commented May 29, 2024
View reviewed changes
Copy link
Contributor Author

@Saipradyumnagoud Saipradyumnagoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Have modified main ReadMe File

README.md
@@ -278,8 +278,7 @@ This repository also provides one such platforms where contributers come over an
| [Arkanoid_Game](https://github.com/kunjgit/GameZone/tree/main/Games/Arkanoid_Game) |
| [Catch_Stars](https://github.com/Kunjgit/GameZone/tree/main/Games/Catch_Stars) |
| [LaserDarts] (https://github.com/Jagpreet153/GameZone/tree/main/Games/LaserDarts)
| [Block Building](https://github.com/kunjgit/GameZone/tree/main/Games/Block_Building) |
|[Flames-Game](https://github.com/Saipradyumnagoud/GameZone/tree/main/Games/Flames-game) |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified Main ReadMe file

@Saipradyumnagoud
Copy link
Contributor Author

Hello @Saipradyumnagoud, You need to make the following changes:

  • Please modify the main README.md file.

Hoping that you will make those changes soon 🚀

I Have modified Main ReadMe.md file please check it

@kunjgit
Copy link
Owner

kunjgit commented May 29, 2024

@Saipradyumnagoud you are having submodule in your code make sure you are following proper guidelines !
make PR again after that!

@kunjgit kunjgit closed this May 29, 2024
@kunjgit
Copy link
Owner

kunjgit commented May 29, 2024

Thank you @Saipradyumnagoud , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunjgit kunjgit kunjgit requested changes

Assignees
No one assigned
Labels
Changes Requested ⚒️ Changes have to be done Pending ⏱️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New game]: FLames game?
2 participants
@Saipradyumnagoud @kunjgit