## **File naming conventions 📁** -- Give unique name for your game that is not already existed +- Give unique name for your game that don't exist already. * Folder naming convention - - ```Game_Name``` ex. ```Tilting_Maze``` (first letter should be capital and if you need space use _ ) + - ```Game_Name``` ex. ```Tilting_Maze```,```Rock_Paper_Scissors``` (first letter should be capital and if you need space use underscore **_** ) * files in the folder - - ```index.html``` , ```script.js``` , ```style.css```(not stictly to follow this but you should have separate ) + - Main html file should be named as **index.html** , not something else like ```Tilting_Maze.html```(Preferred) + - Game files - ```index.html``` , ```script.js``` , ```style.css```(not stictly to follow this but you should have separate file for each kind) + - It is preferred if the main html file is directly added to the main folder of you game like ```Tilting_Maze/index.html``` along with other files like **style.css**, **script.js** - you can have other folders if you are having assets for your game - - ```README.md``` for your folder using template [TEMPLATE](../Games/FOLDER_README_TEMPLATE.md) - - It is not compulsory to follow this README template only you can have your own + - Create```README.md``` for your Game using this [TEMPLATE](../Games/FOLDER_README_TEMPLATE.md).Although, it is not compulsory to follow this README template ,you can use your own *README* template whichever you prefer, to explain functionality and code of your Game * naming convention for the screenshot you will add in ```assets/images``` - - name of image should be same as your game name - - ex. ```Tilting_Maze.jpeg``` or .jpg or .png any of the image formate + - Remember preview image should be in ```assets/images``` and not in main folder of Game itself. + - Name of image should be same as your Game name + - ex. ```Tilting_Maze.jpeg``` or .jpg or .png any of the image format, but don't add image format in the name itself , it is self-assigned to a image, you don't need to add it manually, otherwise it becomes ```Tilting_Maze.jpeg.jpeg``` + - There should be only one ScreenShot of the game in ```assets/images``` and that too with same name as the Game (Exactly Same). +* Note:-All Other data except the ScreenShot of your Game, should be in it's main folder , don't add it to other folders of the project. + +
+ +## Add Game to assets/js/gamesData.json + +* This is to Show your game on the main Website + - Go to the end of gamesData.json and add : + - **,** + " **No.** ":{ + "gameTitle" : " **Title** ", + "gameUrl": " **Main Folder** ", + "thumbnailUrl":" **Preview Image** " + } + - **No.**: Number for your Game , it should be the next number with respect to the file. eg: if the last no. in file at present is *625* you should put *626* at the place of **No.** + - **Title:** this is the title for your game that will be shown on the website, if your game name is ```Super_Mario_Game``` ,put Title as ```Super Mario Game``` + - **Main Folder :** This is the reference to *index.html* + - if your index.html is directly in main game folder ,put the main folder name eg: ```Super_Mario_Game``` + - if your index.html is in subfolder , give path to it + eg: ```Super_Mario_Game/public``` (assuming index.html is in public folder of Super_Mario_Game folder) + - if your main html file's name is not index.html , you need to specify the main html file also. eg:```Super_Mario_Game/mario.html``` or if in sub folder ```Super_Mario_Game/public/mario.html``` + - **Preview Image:** This is the image that will be shown as preview for your game , here you provide the name of the image that you added to **assets/images** folder, along with format type. Eg. ```Super_Mario_Game.png``` or ```Super_Mario_Game.jpg``` or with any other format. + +**Note:-** + + - Do not modify anything else in the rest of the file, you only need to add your game in the end of the file. + - Don't forget to add the comma for new entry (already give in above sample but this is a reminder as one might miss it to see in the sample) +
@@ -54,11 +122,13 @@ in case you are stuck: 1. Ensure that you have self reviewed your code 😀 2. Make sure you have added the proper description for the functionality of the code -3. You have added README file in your repository . -4. You have added the thumbnail of the project into ```assets/images``` for website preview -5. Add your game screenshot in the assets folder by following the proper conversion specified over here -6. You have added your game name and link in main README.md -7. Submit your PR by giving the necesarry information in PR template and hang tight we will review it really soon 🚀 +3. You have added README file in your Game folder. +4. You have added the thumbnail of the project/Game into ```assets/images``` for website preview +5. Added your game screenshot in the assets folder by following the proper conversion specified over here +6. You have added your game name and link in GameZone's README.md +7. You have Added your game to ```assets\js\gamesData.json```. +8. you have reviewed that your Game loads on the website with preview image and works when opened. +9. Submit your PR by giving the necesarry information in PR template and hang tight we will review it really soon 🚀
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 3c364b3fb2..20bc5bbfdb 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -15,10 +15,11 @@ Fixes #
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 860bc55dac..6f922535fc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -73,29 +73,60 @@ If you find this project helpful, please consider giving it a star on GitHub! Yo
## **File naming conventions 📁** -- Give unique name for your game that is not already existed +- Give unique name for your game that don't exist already. * Folder naming convention - - ```Game_Name``` ex. ```Tilting_Maze``` (first letter should be capital and if you need space use _ ) + - ```Game_Name``` ex. ```Tilting_Maze```,```Rock_Paper_Scissors``` (first letter should be capital and if you need space use underscore **_** ) * files in the folder - - ```index.html``` , ```script.js``` , ```style.css```(not stictly to follow this but you should have separate ) + - Main html file should be named as **index.html** , not something else like ```Tilting_Maze.html```(Preferred) + - Game files - ```index.html``` , ```script.js``` , ```style.css```(not stictly to follow this but you should have separate file for each kind) + - It is preferred if the main html file is directly added to the main folder of you game like ```Tilting_Maze/index.html``` along with other files like **style.css**, **script.js** - you can have other folders if you are having assets for your game - - ```README.md``` for your folder using template [TEMPLATE](../Games/FOLDER_README_TEMPLATE.md) - - It is not compulsory to follow this README template only you can have your own + - Create```README.md``` for your Game using this [TEMPLATE](../Games/FOLDER_README_TEMPLATE.md).Although, it is not compulsory to follow this README template ,you can use your own *README* template whichever you prefer, to explain functionality and code of your Game * naming convention for the screenshot you will add in ```assets/images``` - - name of image should be same as your game name - - ex. ```Tilting_Maze.jpeg``` or .jpg or .png any of the image formate + - Remember preview image should be in ```assets/images``` and not in main folder of Game itself. + - Name of image should be same as your Game name + - ex. ```Tilting_Maze.jpeg``` or .jpg or .png any of the image format, but don't add image format in the name itself , it is self-assigned to a image, you don't need to add it manually, otherwise it becomes ```Tilting_Maze.jpeg.jpeg``` + - There should be only one ScreenShot of the game in ```assets/images``` and that too with same name as the Game (Exactly Same). +* Note:-All Other data except the ScreenShot of your Game, should be in it's main folder , don't add it to other folders of the project.
+ +## Add Game to assets/js/gamesData.json + +* This is to Show your game on the main Website + - Go to the end of gamesData.json and add : + - **,** + " **No.** ":{ + "gameTitle" : " **Title** ", + "gameUrl": " **Main Folder** ", + "thumbnailUrl":" **Preview Image** " + } + - **No.**: Number for your Game , it should be the next number with respect to the file. eg: if the last no. in file at present is *625* you should put *626* at the place of **No.** + - **Title:** this is the title for your game that will be shown on the website, if your game name is ```Super_Mario_Game``` ,put Title as ```Super Mario Game``` + - **Main Folder :** This is the reference to *index.html* + - if your index.html is directly in main game folder ,put the main folder name eg: ```Super_Mario_Game``` + - if your index.html is in subfolder , give path to it + eg: ```Super_Mario_Game/public``` (assuming index.html is in public folder of Super_Mario_Game folder) + - if your main html file's name is not index.html , you need to specify the main html file also. eg:```Super_Mario_Game/mario.html``` or if in sub folder ```Super_Mario_Game/public/mario.html``` + - **Preview Image:** This is the image that will be shown as preview for your game , here you provide the name of the image that you added to **assets/images** folder, along with format type. Eg. ```Super_Mario_Game.png``` or ```Super_Mario_Game.jpg``` or with any other format. + +**Note:-** + + - Do not modify anything else in the rest of the file, you only need to add your game in the end of the file. + - Don't forget to add the comma for new entry (already give in above sample but this is a reminder as one might miss it to see in the sample) +
## **Pull Request Process 🚀** 1. Ensure that you have self reviewed your code 😀 2. Make sure you have added the proper description for the functionality of the code -3. You have added README file in your repository . -4. You have added the thumbnail of the project into ```assets/images``` for website preview -5. Add your game screenshot in the assets folder by following the proper conversion specified over here -6. You have added your game name and link in main README.md -7. Submit your PR by giving the necesarry information in PR template and hang tight we will review it really soon 🚀 +3. You have added README file in your Game folder. +4. You have added the thumbnail of the project/Game into ```assets/images``` for website preview +5. Added your game screenshot in the assets folder by following the proper conversion specified over here +6. You have added your game name and link in GameZone's README.md +7. You have Added your game to ```assets\js\gamesData.json```. +8. you have reviewed that your Game loads on the website with preview image and works when opened. +9. Submit your PR by giving the necesarry information in PR template and hang tight we will review it really soon 🚀
diff --git a/Games/.DS_Store b/Games/.DS_Store index 2446c112bf..442634d4c6 100644 Binary files a/Games/.DS_Store and b/Games/.DS_Store differ diff --git a/Games/1icon.png b/Games/1icon.png deleted file mode 100644 index 821142c96f..0000000000 Binary files a/Games/1icon.png and /dev/null differ diff --git a/Games/2048_win/script.js b/Games/2048_win/script.js index 04aab052b8..1545915c32 100644 --- a/Games/2048_win/script.js +++ b/Games/2048_win/script.js @@ -51,14 +51,17 @@ function cellCreator(c, timeOut) { } var randomValue = Math.floor(Math.random() * 4 + 1); //create value 1, 2, 3 or 4 + if (randomValue == 2){ + randomValue =2; + } if (randomValue == 3) { - randomValue = 2; + randomValue = 4; } //3 --> 4 if (randomValue == 1) { randomValue = 2; } //1 --> 2 if (randomValue == 4) { - randomValue = 2; + randomValue = 4; } //4-->2 var position = document.getElementById("" + randomX + randomY); var tile = document.createElement("DIV"); //create div at x, y diff --git a/Games/Alien_Invasion/asset/Macbook-Air.png b/Games/Alien_Invasion/asset/Macbook-Air.png new file mode 100644 index 0000000000..a1fa56b1d8 Binary files /dev/null and b/Games/Alien_Invasion/asset/Macbook-Air.png differ diff --git a/Games/Alien_Invasion/asset/Mobile.png b/Games/Alien_Invasion/asset/Mobile.png new file mode 100644 index 0000000000..8c0ec401ec Binary files /dev/null and b/Games/Alien_Invasion/asset/Mobile.png differ diff --git a/Games/Alien_Invasion/asset/iPad-PRO-11.png b/Games/Alien_Invasion/asset/iPad-PRO-11.png new file mode 100644 index 0000000000..4040d94f1a Binary files /dev/null and b/Games/Alien_Invasion/asset/iPad-PRO-11.png differ diff --git a/Games/Alien_Invasion/index.html b/Games/Alien_Invasion/index.html index 760bb1af1b..cbb245a886 100644 --- a/Games/Alien_Invasion/index.html +++ b/Games/Alien_Invasion/index.html @@ -1,44 +1,18 @@ - - - -
- 
- 
- 
- 
- 
+
+
+
-
-
- Score: 0
+
+
+ 
- 
- 
- 
-
-
- 
- 
- 
- 
-
-
-
-
\ No newline at end of file
+