Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ELU and tanh Activation Functions #97

Open
LeaE opened this issue Jan 23, 2020 · 2 comments
Open

Support for ELU and tanh Activation Functions #97

LeaE opened this issue Jan 23, 2020 · 2 comments

Comments

@LeaE
Copy link

LeaE commented Jan 23, 2020

Hi Avanti,

as far as I can tell from the README and Code, DeepLIFT does currently not support the ELU and tanh activations. Are there any plans to add these features in the near future?

Thanks a lot,
Lea

@AvantiShri
Copy link
Collaborator

Hi @LeaE, just wanted to quickly confirm that this DeepLIFT implementation does not currently support ELU or tanh, but the DeepLIFT implementations listed here do: https://github.com/kundajelab/deeplift#my-model-architecture-is-not-supported-by-this-deeplift-implementation-what-should-i-do (the caveat is that they don't support the RevealCancel rule). I can try to find time to add them in this week, but if you were interested in making a pull request, I would be also be happy to accept it!

@LeaE
Copy link
Author

LeaE commented Feb 7, 2020

Hi Avanti,

thanks for the info! Sorry for my late response, I will have a look at these links and get back to you.

Kind reards,
Lea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants