Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): use newer Kong/public-shared-actions #9502

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Mar 5, 2024

We need Kong/public-shared-actions#95 to make this work on self-hosted runners

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

We need Kong/public-shared-actions#95 to
make this work on self-hosted runners

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana added the ci/skip-e2e-test PR: Don't run e2e tests label Mar 5, 2024
@lahabana lahabana requested a review from a team as a code owner March 5, 2024 15:46
@lahabana lahabana requested review from jakubdyszkiewicz, Automaat and lukidzi and removed request for a team March 5, 2024 15:46
@lahabana lahabana enabled auto-merge (squash) March 5, 2024 15:56
@lahabana lahabana merged commit a70cea5 into kumahq:master Mar 5, 2024
19 checks passed
@lahabana lahabana deleted the useNewerSharedActions branch March 29, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-e2e-test PR: Don't run e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants