fix: correct error handling in processAsync
#4226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ahnpnl would be nice to get this out in v29. Also, the failing test on CI fails on |
|
LGTM though not sure why e2e test failed. The e2e setup is similar to Jest e2e btw. Maybe you can take a look? |
|
Hmm other PRs have the same issue with the tests. I will try to check |
ahnpnl
force-pushed
the
handle-errors-in-process-async
branch
from
9d21986
to
f2d9ad3
Compare
ahnpnl
force-pushed
the
handle-errors-in-process-async
branch
from
f2d9ad3
to
2ebf2c1
Compare
Pull Request Test Coverage Report for Build 7582336836
💛 - Coveralls |
ahnpnl
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4207
Test plan
Copied the changed code into the repo from jestjs/jest#14719 and verified the error is correctly displayed.
I don't have time to write an actual unit test for this, so if that's needed to merge that contribution will have to come from somebody else 😅
Does this PR introduce a breaking change?
Other information
Ignore whitespace when looking at the diff: https://github.com/kulshekhar/ts-jest/pull/4226/files?w=1
Also, should enable: https://eslint.org/docs/latest/rules/no-async-promise-executor