From eb029ab068afb314a892f8945e960813118f71a1 Mon Sep 17 00:00:00 2001 From: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Date: Mon, 15 Nov 2021 12:49:35 -0600 Subject: [PATCH] fix(sql lab): NULL styling in grid cell (#17385) * Fix NULL styling in gridCell * removed unnecessary imports * Added null styling back to renderGridCell * Cleaned up a little code as per Elizabeth * Found another little cleanup spot --- .../components/FilterableTable/FilterableTable.tsx | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/superset-frontend/src/components/FilterableTable/FilterableTable.tsx b/superset-frontend/src/components/FilterableTable/FilterableTable.tsx index e6605fcfc0de2..97149073bac5b 100644 --- a/superset-frontend/src/components/FilterableTable/FilterableTable.tsx +++ b/superset-frontend/src/components/FilterableTable/FilterableTable.tsx @@ -426,14 +426,9 @@ export default class FilterableTable extends PureComponent< }) { const columnKey = this.props.orderedColumnKeys[columnIndex]; const cellData = this.list[rowIndex][columnKey]; + const cellText = this.getCellContent({ cellData, columnKey }); const content = - cellData === null ? ( - - {this.getCellContent({ cellData, columnKey })} - - ) : ( - this.getCellContent({ cellData, columnKey }) - ); + cellData === null ? {cellText} : cellText; const cellNode = (
{cellNode} : cellNode; const jsonObject = safeJsonObjectParse(cellData); if (jsonObject) { return this.addJsonModal(cellNode, jsonObject, cellData); } - return cellNode; + return content; } renderTable() {