Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WORKSPACE #3368

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update WORKSPACE #3368

wants to merge 5 commits into from

Conversation

kpol-lgx
Copy link

@kpol-lgx kpol-lgx commented Aug 6, 2024 •
edited
Loading

Delete one of the two identical lines.

What this PR does / why we need it:
At the beginning of WORKSPACE, the parameters of the two load functions are exactly the same. So maybe one of them should be removed.

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive", "http_file")
load(
    "@bazel_tools//tools/build_defs/repo:http.bzl",
    "http_archive",
    "http_file",
)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

cfilleke and others added 2 commits December 1, 2023 11:42
@cfilleke
Create build-the-builder.md
e3a37a6 
Document the manual build of CDI builder helper container and typical make targets

Signed-off-by: cfillekes <[email protected]>
@kpol-lgx
Update WORKSPACE
938d25c 
Delete one of the two identical lines.

Signed-off-by: Gxliu <[email protected]>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Aug 6, 2024
@kubevirt-bot kubevirt-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 6, 2024
@kubevirt-bot
Copy link
Contributor

Hi @kpol-lgx. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added size/XS release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 6, 2024
@kpol-lgx
Merge pull request #1 from cfilleke/patch-4
6ce2893 
Create build-the-builder.md
@kpol-lgx
Update build-the-builder.md
8120a03 
change the option of BUILD_ARCH.
cover arm64 with aarch64.

Signed-off-by: Gxliu <[email protected]>
@kpol-lgx
Merge branch 'kubevirt:main' into main
12bfb04
@awels
Copy link
Member

awels commented Aug 8, 2024

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2024
@akalenyu
Copy link
Collaborator

akalenyu commented Aug 8, 2024

/hold
weird, 5 commits?

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2024
@awels
Copy link
Member

awels commented Aug 8, 2024

It will get squashed into a single commit before merging.

@akalenyu
Copy link
Collaborator

akalenyu commented Aug 8, 2024

It will get squashed into a single commit before merging.

Hmm look at the diff, it looks like unrelated changes and commits got pulled into this PR

@awels
Copy link
Member

awels commented Aug 8, 2024

I see the WORKSPACE and the documentation changes. Are you seeing something else?

@akalenyu
Copy link
Collaborator

akalenyu commented Aug 8, 2024

I see the WORKSPACE and the documentation changes. Are you seeing something else?

image

@awels
Copy link
Member

awels commented Aug 8, 2024

So you want just the WORKSPACE and not the documentation change?

@akalenyu
Copy link
Collaborator

akalenyu commented Aug 8, 2024

So you want just the WORKSPACE and not the documentation change?

Yes, I doubt the author wants to pull someone elses commit as well

@kubevirt-bot
Copy link
Contributor

@kpol-lgx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdi-apidocs 12bfb04 link false /test pull-cdi-apidocs
pull-containerized-data-importer-e2e-hpp-previous 12bfb04 link true /test pull-containerized-data-importer-e2e-hpp-previous
pull-containerized-data-importer-e2e-ceph-wffc 12bfb04 link true /test pull-containerized-data-importer-e2e-ceph-wffc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2024
@kubevirt-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aglitke aglitke Awaiting requested review from aglitke

@akalenyu akalenyu Awaiting requested review from akalenyu

Assignees

@awels awels

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kpol-lgx @kubevirt-bot @awels @akalenyu @cfilleke