Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cell renderers for providers vm list #719

Closed
4 tasks done
yaacov opened this issue Sep 8, 2023 · 8 comments
Closed
4 tasks done

Improve cell renderers for providers vm list #719

yaacov opened this issue Sep 8, 2023 · 8 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone

Comments

@yaacov
Copy link
Member

yaacov commented Sep 8, 2023

In #670 we added better columns and filters for the vm list, we also need to go over the cell renderes and improve them.

For example:
concerns: show all concerns as multi line table, should be one line that will give the user all the information in a visually easy to consume information.
status: in vmware list we show the power status, a. it's not clean that "status" mean "power status", b. currently we show text "powerOn/powerOf" we should show a nice visually clear color icon for on/off instead.

concerns and powerstatus are examples of columns we can improve, please comment below if you feel other columns can be improved.

sub tasks:

  • map out the fields we want to show for each provider
  • see that we have the information in the inventory
  • create cell renderers
  • implement specific vm list for each provider type
@yaacov yaacov added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 8, 2023
@yaacov yaacov added this to the 2.5.1 milestone Sep 8, 2023
@yaacov yaacov modified the milestones: 2.5.1, 2.5.2 Sep 20, 2023
@yaacov yaacov modified the milestones: 2.5.2, 2.6.0 Oct 15, 2023
@yaacov
Copy link
Member Author

yaacov commented Oct 25, 2023

@rszwajko ping, what is the status of this issue ?

what is already done ?

  • map out the fields we want to show for each provider
  • see that we have the information in the inventory
  • create cell renderers
  • implement specific vm list for each provider type

@yaacov yaacov assigned rszwajko and unassigned rszwajko Oct 25, 2023
@rszwajko
Copy link
Contributor

rszwajko commented Oct 25, 2023

map out the fields we want to show for each provider

Done in #708 for non-k8s providers. Done in #741, #742 and #723 for OpenShift.
I'll provide fields/column summary in a separate comment.

see that we have the information in the inventory

Done in #728

implement specific vm list for each provider type

Done in #708 and #729

create cell renderers

Done - added power status renderer in #723, changed concerns renderer in #733

@yaacov
Copy link
Member Author

yaacov commented Oct 25, 2023

@rszwajko hi,

map out the fields we want to show for each provider

can you wirte here the lists per provider, so we can start discus them ?

@rszwajko
Copy link
Contributor

rszwajko commented Oct 25, 2023

  1. OpenShift columns:
    • name,
    • power status,
    • template name

image

  1. OVA columns:
    • name,
    • concerns,
    • OVA path

image

  1. oVirt columns:
    • name,
    • concerns,
    • cluster,
    • host,
    • path,
    • power status,
    • description

image

  1. OpenStack columns:
    • name
    • concerns
    • host ID
    • path
    • power status,
    • tenant ID
    • image ID
    • flavor ID

image

  1. vSphere columns :
    • name
    • concerns
    • isTemplate
    • host
    • path
    • power status

image

@ahadas @bennyz @bkhizgiy
above is the list of currently displayed columns. In the links you can find field-to-column mapping.
Please review and comment here if we should add/remove some columns and/or improve the visual side (i.e. colors, icons, etc).

@bkhizgiy
Copy link
Member

bkhizgiy commented Dec 5, 2023

@rszwajko From OVA prospective looking good, I don't think any additional fields are required.

@yaacov
Copy link
Member Author

yaacov commented Jan 2, 2024

@rszwajko hi,

Update

  • OVA
  • Openstack
  • vMware
  • oVirt
  • Openshift - need to add namespace == "object->metadate->namespace"

@yaacov
Copy link
Member Author

yaacov commented Jan 4, 2024

Adding #812 to the list

TODO:

@yaacov
Copy link
Member Author

yaacov commented Jan 11, 2024

closing:

@yaacov yaacov closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

3 participants