From ab7a45ae6b042ac445f2a8cd403fa6e3b976c818 Mon Sep 17 00:00:00 2001
From: Sharon Gratch <sgratch@redhat.com>
Date: Wed, 4 Dec 2024 00:57:02 +0200
Subject: [PATCH] Avoid displaying alert messages for successfully completed
 plans

Reference: https://issues.redhat.com/browse/MTV-1730

If plan was completed succesfully, it's irrelevant to display critical
errors or warnings alerts in page header.

Signed-off-by: Sharon Gratch <sgratch@redhat.com>
---
 .../details/components/PlanPageHeadings.tsx   | 52 +++++++++++--------
 1 file changed, 31 insertions(+), 21 deletions(-)

diff --git a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/PlanPageHeadings.tsx b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/PlanPageHeadings.tsx
index 9f1f399d4..07a966258 100644
--- a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/PlanPageHeadings.tsx
+++ b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/PlanPageHeadings.tsx
@@ -79,27 +79,35 @@ export const PlanPageHeadings: React.FC<{ name: string; namespace: string }> = (
     return isPreserveStaticIPs && isMapToPod;
   };
 
-  if (criticalCondition) {
-    alerts.push(
-      <PlanCriticalCondition
-        type={criticalCondition?.type}
-        message={criticalCondition?.message}
-        key={'providerCriticalCondition'}
-      />,
-    );
-  } else if (preserveIpsWithPodMapCondition()) {
-    alerts.push(
-      <PlanWarningCondition
-        type={t('Preserving static IPs of VMs might fail')}
-        message={t(
-          'The plan is set to preserve the static IPs of VMs mapped to a Pod network type. This is not supported and therefore VM IPs can be changed during the migration process.',
-        )}
-        suggestion={t(
-          "For fixing, update the destination network mappings to avoid using the 'Pod Networking' type.",
-        )}
-      />,
-    );
-  }
+  const handleAlerts = () => {
+    // alerts are not relevant to display if plan was completed successfully
+    if (planStatus === 'Succeeded') return;
+
+    if (criticalCondition) {
+      alerts.push(
+        <PlanCriticalCondition
+          type={criticalCondition?.type}
+          message={criticalCondition?.message}
+          key={'providerCriticalCondition'}
+        />,
+      );
+      return;
+    }
+
+    if (preserveIpsWithPodMapCondition()) {
+      alerts.push(
+        <PlanWarningCondition
+          type={t('Preserving static IPs of VMs might fail')}
+          message={t(
+            'The plan is set to preserve the static IPs of VMs mapped to a Pod network type. This is not supported and therefore VM IPs can be changed during the migration process.',
+          )}
+          suggestion={t(
+            "For fixing, update the destination network mappings to avoid using the 'Pod Networking' type.",
+          )}
+        />,
+      );
+    }
+  };
 
   const onClick = () => {
     showModal(
@@ -123,6 +131,8 @@ export const PlanPageHeadings: React.FC<{ name: string; namespace: string }> = (
     </Level>
   );
 
+  handleAlerts();
+
   return (
     <>
       <PageHeadings