Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: tests(integration): Move integration tests to tests/ #340

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: tests(integration): Move integration tests to tests/ #340

wants to merge 1 commit into from
+92 −168

Conversation

Bhargav-InfraCloud
Copy link
Contributor

@Bhargav-InfraCloud Bhargav-InfraCloud commented Mar 5, 2024 •
edited
Loading

Description

Move integration tests to tests/.

Fixes #297

How Has This Been Tested?

Run the following commands and check if running successful:

# This should print all the tests related commands under a separate heading
make help

# Individual types of tests
make test-unit
make test-coverage
make test-integration

# These should run all the above tests
make test
make test-docker

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have ran go fmt
  • I have updated the helm chart as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit test cases.
  • I have verified the E2E test cases with new code changes.
  • I have added all the required E2E test cases.

Does this PR introduce a breaking change?

@Bhargav-InfraCloud Bhargav-InfraCloud force-pushed the br_reorganize_tests branch 4 times, most recently from 3fcd049 to 4f528ab Compare March 12, 2024 10:35
@Bhargav-InfraCloud Bhargav-InfraCloud force-pushed the br_reorganize_tests branch 2 times, most recently from 4f02c6e to 427a2c6 Compare April 6, 2024 22:47
@Bhargav-InfraCloud
tests(integration): Move integration tests to tests/
10b9854 
Move tests-related targets in Makefile to a separate section `Test`.

Signed-off-by: Bhargav Ravuri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narmidm narmidm Awaiting requested review from narmidm narmidm will be requested when the pull request is marked ready for review narmidm is a code owner

@bharath-avesha bharath-avesha Awaiting requested review from bharath-avesha bharath-avesha will be requested when the pull request is marked ready for review bharath-avesha is a code owner

@richiesebastian richiesebastian Awaiting requested review from richiesebastian richiesebastian will be requested when the pull request is marked ready for review richiesebastian is a code owner

@Rahul-D78 Rahul-D78 Awaiting requested review from Rahul-D78 Rahul-D78 will be requested when the pull request is marked ready for review Rahul-D78 is a code owner

@gourishkb gourishkb Awaiting requested review from gourishkb gourishkb will be requested when the pull request is marked ready for review gourishkb is a code owner

@mridulgain mridulgain Awaiting requested review from mridulgain mridulgain will be requested when the pull request is marked ready for review mridulgain is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Separating UTs & ITs for better visibility on coverage
1 participant
@Bhargav-InfraCloud