Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Pull Request template to the repo #35

Closed
gourishkb opened this issue Feb 5, 2024 · 7 comments · Fixed by #38
Closed

Add a Pull Request template to the repo #35

gourishkb opened this issue Feb 5, 2024 · 7 comments · Fixed by #38
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@gourishkb
Copy link
Contributor

PR format needs to be standardized and follow the guidelines followed across kubeslice org.

@gourishkb gourishkb self-assigned this Feb 5, 2024
@narmidm narmidm added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 5, 2024
@gourishkb gourishkb added the good first issue Good for newcomers label Feb 19, 2024
@yash2189
Copy link
Contributor

Hello I would like to contribute on this issue if it is up for grabs.

@narmidm narmidm assigned yash2189 and unassigned gourishkb Mar 29, 2024
@narmidm narmidm moved this to In Progress in KubeSlice Roadmap Mar 29, 2024
@narmidm
Copy link
Member

narmidm commented Mar 29, 2024

sure @yash2189. I have assigned this issue to you.

@narmidm
Copy link
Member

narmidm commented Apr 4, 2024

Let us know @yash2189 if you need any help with this issue.

@yash2189
Copy link
Contributor

yash2189 commented Apr 4, 2024

sure @narmidm

@yash2189
Copy link
Contributor

yash2189 commented Apr 4, 2024

@narmidm I wanted to understand the guidelines for PR's that are followed across kubeslice org so I can start working on creating the PR template
for eg: Do we have any Dependency(on third party service) , DB Migration , any Security Checklist that is followed?
Additionally , I went through worker-operator repo within kubeslice where I came across the PR template file. Is this something similar that needs to be added as a part of this PR?

@narmidm
Copy link
Member

narmidm commented Apr 8, 2024

ye @yash2189, you can put same PR template like worker-operator repo.

@narmidm
Copy link
Member

narmidm commented Apr 8, 2024

for other community guideline docs.

you can follow this issue - kubeslice/router-sidecar#48 to understand & add those in kubeslice-monitoring repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants