replace special chars in user names #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatousJobanek
requested review from
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
mfrancisc,
drpaneas,
metlos and
fbm3307
as code owners
MatousJobanek
commented
Dec 17, 2024
|
|
||
| var specialCharRegexp = regexp.MustCompile("[^A-Za-z0-9]") | ||
|
|
||
| func sanitizeUserName(userName string) string { |
There was a problem hiding this comment.
before you start asking why I didn't use the already existing functions, I was thinking about it, but decided to use this simple option, the reasons are:
- transforming username from toolchain-common - the usage is different, it cuts the name of the username (to keep it short) as it expects that it would be used together with the namespace/space suffixes. It also does some assumptions with
@char. - transforming usersignup name that is in registration service - yes, we could use this one, but we would need to move it to toolchain-common first. However, I thought that we don't need any extra logic of generating the sha in case there is some special char in the username. TBH, the risk of having a conflict of the names is very low, so I would rather keep it simple and let the transformation that is in reg-service fully optimized for the usage for UserSignup names.
There was a problem hiding this comment.
Thanks for this explanation :D
xcoulon
approved these changes
Dec 17, 2024
|
let me close this one - it should rather fail if the name is not compliant than doing some additional replacements |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 67.78% 67.84% +0.05%
==========================================
Files 44 44
Lines 3216 3222 +6
==========================================
+ Hits 2180 2186 +6
Misses 841 841
Partials 195 195
|
|
the correct fix is here: #94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so the username can be used as the name of the User resource as well as the label value