-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Docsy 0.5.1 via NPM module #48812
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Patrice Chalin <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify site configuration. |
6f9c896
to
8f41bef
Compare
<meta name="description" content="{{ template "partials/page-description.html" . }}"> | ||
<meta property="og:description" content="{{ template "partials/page-description.html" . }}"> | ||
<meta name="twitter:description" content="{{ template "partials/page-description.html" . }}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Signed-off-by: Patrice Chalin <[email protected]>
8f41bef
to
b745980
Compare
Try running |
Hope this is OK |
…n icon Signed-off-by: Patrice Chalin <[email protected]>
@sftim wrote via #48811 (comment):
Yes, here's the fix I propose: a65258e. It looks like this: which you can see via https://deploy-preview-48812--kubernetes-io-main-staging.netlify.app/docs/concepts/windows/. |
@sftim - with the latest changes, this is ready for reivew -- and so not WIP. The Docker & build script issues being orthogonal to the Docsy upgrade. |
If this breaks local previewing in a container, we can't merge it. Anyway, based on #48812 (comment) /retitle Upgrade to Docsy 0.5.1 via NPM module |
fixes Bootstrap and Font Awesome (as part of Docsy) are deprecated #32905
fixes Use canonical FontAwesome v6 icon names, upgrading from v3-v5 #48811
template "partials/page-description.html"
to generate HTML header page meta descriptions. (This template has continued to be improved, with the most recent update being made in Docsy 0.11.0.)static
Bootstrap resources, keeping the one needed by the API pages.Also addresses and closes the following:
Previews
Checks I've done
I've checked that the following render correctly, feel free to double check:
Followup changes
This PR makes minimal changes. Consider following up with updates to:
docker.io/library/debian:bookworm
as @sftim proposed in Bump Docsy to 0.4.x #48722tabpane
shortcode #48814border
on the.mermaid
class