Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: consider use --lazy option for unconnected nfs server when cleanup node mountpoints #2980

Closed
zhangzhiqiangcs opened this issue Dec 12, 2023 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Milestone

Comments

@zhangzhiqiangcs
Copy link

zhangzhiqiangcs commented Dec 12, 2023

What would you like to be added?

kubeadm cleanup load try --lazy option when encounting umount nfs error.
umount reference: https://linux.die.net/man/8/umount

Why is this needed?

The kubeadm command may hangs if the node can not connect to nfs server

@zhangzhiqiangcs zhangzhiqiangcs added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 12, 2023
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 12, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhangzhiqiangcs
Copy link
Author

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 12, 2023
@neolit123
Copy link
Member

/transfer kubeadm

@k8s-ci-robot k8s-ci-robot transferred this issue from kubernetes/kubernetes Dec 12, 2023
@neolit123 neolit123 added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Dec 12, 2023
@neolit123 neolit123 added this to the v1.30 milestone Dec 12, 2023
@neolit123
Copy link
Member

please add more details to the description.

where is this --lazy flag supposed to be added?
is it for "kubeadm reset"?

if yes, then maybe this is a related issue:
#2923

and PR:
kubernetes/kubernetes#120377

@zhangzhiqiangcs
Copy link
Author

zhangzhiqiangcs commented Dec 13, 2023

please add more details to the description.

where is this --lazy flag supposed to be added? is it for "kubeadm reset"?

if yes, then maybe this is a related issue: #2923

and PR: kubernetes/kubernetes#120377

This issue and PR seems is just what I looked for. Thanks @neolit123

@neolit123
Copy link
Member

ok, we can close this one.
that PR is blocked because we did not agree on how to do the change exactly so that it does not break users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Development

No branches or pull requests

3 participants