Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update learner mode test to test not in etcd learner mode as it is beta #2929

Merged
merged 1 commit into from
Sep 8, 2023
Merged

update learner mode test to test not in etcd learner mode as it is beta #2929

merged 1 commit into from
Sep 8, 2023

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Sep 8, 2023

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2023
@k8s-ci-robot k8s-ci-robot added the area/kinder Issues to track work in the kinder tool label Sep 8, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2023
@neolit123
Copy link
Member

There are no nodes that your pod can schedule to - check your requests, tolerations, and node selectors (skip schedule deleting pod: test-pods/ae467f95-1efa-47b5-9006-bb7226e36ba5)

/retest

neolit123
neolit123 reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member

/kind feature cleanup

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 8, 2023
@neolit123 neolit123 added this to the v1.29 milestone Sep 8, 2023
@neolit123
Copy link
Member

neolit123 commented Sep 8, 2023 •
edited
Loading

looks like these failing -canary jobs were added here without pining us:
kubernetes/test-infra#30480

/skip pull-kubeadm-kinder-upgrade-latest-canary
/skip pull-kubeadm-kinder-verify-canary

@neolit123
Copy link
Member

neolit123 commented Sep 8, 2023 •
edited
Loading

looks like these failing -canary jobs were added here without pining us:

/skip pull-kubeadm-kinder-upgrade-latest-canary /skip pull-kubeadm-kinder-verify-canary

we don't have the skip prow plugin enabled on k/kubeadm
i will send a test-infra PR to fix these problems.

@neolit123
Copy link
Member

/retest

@pacoxu
Copy link
Member Author

pacoxu commented Sep 8, 2023

/test pull-kubeadm-kinder-upgrade-latest-canary
/test pull-kubeadm-kinder-verify-canary

@pacoxu
Copy link
Member Author

pacoxu commented Sep 8, 2023

looks like these failing -canary jobs were added here without pining us: kubernetes/test-infra#30480

Should this be reverted?

@neolit123
Copy link
Member

looks like these failing -canary jobs were added here without pining us: kubernetes/test-infra#30480

Should this be reverted?

we can try keeping it.

@pacoxu
Copy link
Member Author

pacoxu commented Sep 8, 2023

looks like these failing -canary jobs were added here without pining us: kubernetes/test-infra#30480

Should this be reverted?

we can try keeping it.

Add them to the skippable list? Is there an example?

@neolit123
Copy link
Member

looks like these failing -canary jobs were added here without pining us: kubernetes/test-infra#30480

Should this be reverted?

we can try keeping it.

Add them to the skippable list? Is there an example?

fix PR:
kubernetes/test-infra#30658

@neolit123
Copy link
Member

neolit123 commented Sep 8, 2023 •
edited
Loading

once it merges please try /skip <jobname> or /override <jobname>
or just /retest too, i guess.

@pacoxu
Copy link
Member Author

pacoxu commented Sep 8, 2023

/skip

@k8s-ci-robot k8s-ci-robot merged commit c1258e7 into kubernetes:main Sep 8, 2023
@neolit123 neolit123 mentioned this pull request Sep 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@chendave chendave Awaiting requested review from chendave

@RA489 RA489 Awaiting requested review from RA489

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
3 participants
@pacoxu @neolit123 @k8s-ci-robot