Do not add 'namespace: default' by default #1729
Labels
kind/feature
Categorizes issue or PR as related to a new feature.
Comments
cdrage
added
the
kind/feature
cdrage
added a commit
to cdrage/kompose
that referenced
this issue
Oct 11, 2023
#### What type of PR is this? <!-- Add one of the following kinds: /kind cleanup /kind documentation /kind feature --> /kind bug #### What this PR does / why we need it: When we generate the YAML, we should NOT add namespace by default, namespace should only be added if it has been specified via the command line. #### Which issue(s) this PR fixes: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes kubernetes#1729 #### Special notes for your reviewer:
cdrage
added a commit
to cdrage/kompose
that referenced
this issue
Oct 11, 2023
#### What type of PR is this? <!-- Add one of the following kinds: /kind cleanup /kind documentation /kind feature --> /kind bug #### What this PR does / why we need it: When we generate the YAML, we should NOT add namespace by default, namespace should only be added if it has been specified via the command line. #### Which issue(s) this PR fixes: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes kubernetes#1729 #### Special notes for your reviewer: Signed-off-by: Charlie Drage <[email protected]>
cdrage
added a commit
that referenced
this issue
Oct 11, 2023
#### What type of PR is this? <!-- Add one of the following kinds: /kind cleanup /kind documentation /kind feature --> /kind bug #### What this PR does / why we need it: When we generate the YAML, we should NOT add namespace by default, namespace should only be added if it has been specified via the command line. #### Which issue(s) this PR fixes: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes #1729 #### Special notes for your reviewer: Signed-off-by: Charlie Drage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What would you like to be added?
'namespace' is not required and by default should NOT be added, for example, if kompose does not specify
--namespacewhen generating, do not addnamespace: defaultto all generated files.When you apply the yaml via
kubectl, it will apply it to whatever default namespace you are interacting with.Why is this needed?
See: #1667 (comment)
The text was updated successfully, but these errors were encountered: