Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go mod verify script and pre-submit #271

Open
jpbetz opened this issue Nov 16, 2024 · 4 comments
Open

Add go mod verify script and pre-submit #271

jpbetz opened this issue Nov 16, 2024 · 4 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@jpbetz
Copy link
Contributor

jpbetz commented Nov 16, 2024

go.mod should not be allowed to fall out of sync with vendor/modules.txt.

A hack/verify-vendor.sh style script should be added and then a verify presubmit should be added that calls this verify script.

@jpbetz
Copy link
Contributor Author

jpbetz commented Nov 16, 2024

/help

@k8s-ci-robot
Copy link
Contributor

@jpbetz:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 16, 2024
@jpbetz
Copy link
Contributor Author

jpbetz commented Nov 18, 2024

Alternatively, could we drop vendor from this repo?

cc @Jefftree

@Jefftree
Copy link
Member

Created a PR to remove vendor. #272

It seems more convenient than having to remember to vendor every time + adding additional CI scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

3 participants