syncing rbac based yamls by manually updating all_in_one.yaml and generating latest helm files using make helm-chart #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erating latest helm files using make helm-chart Signed-off-by: Sanskar Bhushan <[email protected]>
|
I'll review ASAP |
SimonCqk
reviewed
Nov 24, 2023
| @@ -26,25 +26,6 @@ rules: | |||
| - get | |||
| - patch | |||
| - update | |||
| - apiGroups: | |||
| - "coordination.k8s.io" | |||
| resources: | |||
There was a problem hiding this comment.
leases RBAC should be reserved?
|
btw, PR conflicts with master branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
This PR syncs RBAC based rules across different manifests i.e. role.yaml and all_in_one.yaml. Also, this PR generates the latest version of helm charts.
II. Does this pull request fix one issue?
Fixes #257
III. Special notes for reviewers if any.
None