Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] get rid of launcherRunsWorkload global flag #194

Open
SimonCqk opened this issue Oct 14, 2021 · 0 comments · May be fixed by #198
Open

[feature request] get rid of launcherRunsWorkload global flag #194

SimonCqk opened this issue Oct 14, 2021 · 0 comments · May be fixed by #198
Assignees
@SimonCqk

Comments

@SimonCqk
Copy link
Collaborator

SimonCqk commented Oct 14, 2021 •
edited
Loading

What would you like to be added:

as we discussed in #180 (comment), the global flag launcherRunsWorkload can be removed, mpiReplicaSpecs with Launcher role indicates that mpijob will be driven by Launcher pod, which is launcherRunsWorkload semantics.

Why is this needed:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonCqk SimonCqk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(mpi): remove global launcherRunsWorkload flag. SimonCqk/kubedl
1 participant
@SimonCqk