From 3a7e13591a8a871585933a46efc2750112b1da3b Mon Sep 17 00:00:00 2001 From: Ishaan Mittal Date: Fri, 1 Nov 2024 17:50:59 +0530 Subject: [PATCH] remove unneccessary commeennts and configs --- .../values-openshift-cluster-prometheus.yaml | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/cost-analyzer/values-openshift-cluster-prometheus.yaml b/cost-analyzer/values-openshift-cluster-prometheus.yaml index f23b6bc2e..138c54f31 100644 --- a/cost-analyzer/values-openshift-cluster-prometheus.yaml +++ b/cost-analyzer/values-openshift-cluster-prometheus.yaml @@ -1,18 +1,16 @@ -# This helm values file is a modified version of the values-openshift.yaml file that is used to deploy Kubecost on OpenShift. -# The main difference is that the values-openshift-cluster-prometheus.yaml file is configured to connect to the in-cluster Prometheus instance running on the OpenShift cluster and not use bundled prometheus. - +# This Helm values file is a modified version of `values-openshift.yaml`. +# The primary difference is that this file is configured to disable the Kubecost-bundled Prometheus, and instead leverage the Prometheus instance that is typically pre-installed in OpenShift clusters. global: prometheus: - enabled: false # Kubecost depends on Prometheus data, it is not optional. When enabled: false, Prometheus will not be installed and you must configure your own Prometheus to scrape kubecost as well as provide the fqdn below. -- Warning: Before changing this setting, please read to understand the risks https://docs.kubecost.com/install-and-configure/install/custom-prom + enabled: false # Kubecost depends on Prometheus data, it is not optional. When enabled: false, Prometheus will not be installed and you must configure your in-cluster Prometheus to scrape kubecost as well as provide the fqdn below. -- Warning: Before changing using this setting, please read to understand the risks https://docs.kubecost.com/install-and-configure/install/custom-prom fqdn: https://prometheus-k8s.openshift-monitoring.svc.cluster.local:9091 # example address of a Prometheus to connect to. Include protocol (http:// or https://) Ignored if enabled: true insecureSkipVerify: false # If true, kubecost will not check the TLS cert of prometheus - # queryServiceBearerTokenSecretName: mcdbsecret # kubectl create secret generic mcdbsecret -n kubecost --from-file=TOKEN kubeRBACProxy: true # If true, kubecost will use kube-rbac-proxy to authenticate with in cluster Prometheus for openshift grafana: enabled: false # If false, Grafana will not be installed domainName: grafana.grafana proxy: false - # Platforms is a higher-level abstraction for platform-specific values and settings. + platforms: # Deploying to OpenShift (OCP) requires enabling this option. openshift: @@ -21,10 +19,7 @@ global: createMonitoringResourceReaderRoleBinding: true # Create a Role and Role Binding to allow in-cluster Prometheus or Thanos to list and watch resources. This will be necessary if you are not using bundled prometheus and need to add scrape config for resources. monitoringServiceAccountName: prometheus-k8s # Name of the service account to bind to the Resource Reader Role Binding. monitoringServiceAccountNamespace: openshift-monitoring # Namespace of the service account to bind to the Resource Reader Role Binding. - route: - enabled: false # Create an OpenShift Route. - annotations: {} # Add annotations to the Route. - # host: kubecost.apps.okd4.example.com # Add a custom host for your Route. + # Create Security Context Constraint resources for the DaemonSets requiring additional privileges. scc: nodeExporter: false # Creates an SCC for Prometheus Node Exporter. This requires Node Exporter be enabled.