Skip to content
This repository has been archived by the owner on Mar 25, 2020. It is now read-only.

Email notification arrives with PST time zone #148

Open
allcloud-ronen opened this issue Jan 28, 2019 · 4 comments
Open

Email notification arrives with PST time zone #148

allcloud-ronen opened this issue Jan 28, 2019 · 4 comments

Comments

@allcloud-ronen
Copy link

I see that the email notification is hard coded to send the time in PST:

## New Incident Status: ${latestUpdate.status} - ${formatDateTimeInPST(latestUpdate.createdAt)}

Wouldn't it make more sense to make it configurable, or at least hardcode it to UTC which is more universal than PST?
Thanks.

@ks888
Copy link
Owner

ks888 commented Feb 3, 2019

Thank you for your suggestion. Yes, it makes sense to make it configurable, though personally I can't find the enough time to support it.

Also, UTC hardcoding is certainly better than PST. Fortunately we already have the formatDateTime function in utils/datetime and so the changes should be not so difficult. It's great if you have a chance to contribute the code.

@pgrzesik
Copy link

pgrzesik commented Apr 1, 2019

Hello, I'd like to take a stab at it - did you have in mind configuration via env variable or something more advanced?

@ks888
Copy link
Owner

ks888 commented Apr 23, 2019

Sorry for my late reply. If we make it configurable, I think it's better if a user can change the time zone via GUI. In the demo page below, it will be useful if the Notification tab contains the time zone setting item.
https://demo-admin.lambstatus.org/settings

Env variable may be possible, but most users can't change it because they launch their stack using CloudFormation.

@DannyBen
Copy link

I would also love to see this implemented, and seems like an option in the UI is more along the lines of how LambStatus is used and deployed.

However - regardless of this implementation - I believe the default should be changed from PST, to UTC.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants